Skip to content

Commit 3b2afed

Browse files
fix(auth): remove unused useSession, guard invalid-callback warn with ref
1 parent 6932c85 commit 3b2afed

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

apps/sim/app/(auth)/signup/signup-form.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
11
'use client'
22

3-
import { Suspense, useEffect, useMemo } from 'react'
3+
import { Suspense, useEffect, useMemo, useRef } from 'react'
44
import { createLogger } from '@sim/logger'
55
import Link from 'next/link'
66
import { useSearchParams } from 'next/navigation'
7-
import { useSession } from '@/lib/auth/auth-client'
87
import { getEnv, isTruthy } from '@/lib/core/config/env'
98
import { validateCallbackUrl } from '@/lib/core/security/input-validation'
109
import { captureClientEvent } from '@/lib/posthog/client'
@@ -27,15 +26,16 @@ function SignupFormContent({
2726
isProduction,
2827
}: SignupFormProps) {
2928
const searchParams = useSearchParams()
30-
useSession()
29+
const invalidCallbackRef = useRef(false)
3130

3231
useEffect(() => {
3332
captureClientEvent('signup_page_viewed', {})
3433
}, [])
3534

3635
const rawRedirectUrl = searchParams.get('redirect') || searchParams.get('callbackUrl') || ''
3736
const isValidRedirectUrl = rawRedirectUrl ? validateCallbackUrl(rawRedirectUrl) : false
38-
if (rawRedirectUrl && !isValidRedirectUrl) {
37+
if (rawRedirectUrl && !isValidRedirectUrl && !invalidCallbackRef.current) {
38+
invalidCallbackRef.current = true
3939
logger.warn('Invalid callback URL detected and blocked:', { url: rawRedirectUrl })
4040
}
4141
const redirectUrl = isValidRedirectUrl ? rawRedirectUrl : ''

0 commit comments

Comments
 (0)