fix(review): integer rule rounding, success-gated workflow labels, display module hygiene

Second-pass review fixes: round integer rule fields so fractional input
never reaches SQL LIMIT, gate workflow-name readiness on a successful
non-placeholder load in both editor and preview (errored loads mislabeled
valid workflows as deleted), lazily read the variables store in preview
rows, move the filter-field JSON preview into the shared display module
and unexport its single-consumer helpers, and align >= boundary copy
(failure rate, error count, cooldown window) with implementation.

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: icecrasher321

apps/docs/content/docs/en/triggers/sim.mdx

@@ -20,11 +20,11 @@ Pick one event per Sim trigger block:
   <li><strong>Workflow Deployed</strong>: a watched workflow was deployed (including redeploys and version rollbacks)</li>
 </ul>
 
-**Alert conditions** — evaluated as runs complete, with a cooldown so they fire at most once per window:
+**Alert conditions** — evaluated as runs complete, with a cooldown so they fire at most once per cooldown window:
 
 <ul className="list-disc space-y-1 pl-6">
   <li><strong>Consecutive Failures</strong>: the last N runs all failed</li>
-  <li><strong>Failure Rate</strong>: failure rate exceeds a percentage over a time window (minimum 5 runs)</li>
+  <li><strong>Failure Rate</strong>: failure rate meets or exceeds a percentage over a time window (minimum 5 runs)</li>
   <li><strong>Latency Threshold</strong>: a run took longer than a fixed duration</li>
   <li><strong>Latency Spike</strong>: a run was a configurable percentage slower than the recent average (minimum 5 runs)</li>
   <li><strong>Cost Threshold</strong>: a run cost more than a credit threshold</li>

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/workflow-block/workflow-block.tsx

@@ -15,14 +15,13 @@ import { calculateWorkflowBlockDimensions } from '@/lib/workflows/blocks/determi
 import { getConditionRows, getRouterRows } from '@/lib/workflows/dynamic-handle-topology'
 import {
   getDisplayValue,
-  isPlainObject,
   resolveDropdownLabel,
+  resolveFilterFieldLabel,
   resolveSkillsLabel,
   resolveToolsLabel,
   resolveVariablesLabel,
   resolveWorkflowMultiSelectLabel,
   resolveWorkflowSelectionLabel,
-  tryParseJson,
 } from '@/lib/workflows/subblocks/display'
 import {
   buildCanonicalIndex,
@@ -246,16 +245,26 @@ const SubBlockRow = memo(function SubBlockRow({
   )
   const knowledgeBaseDisplayName = kbForDisplayName?.name ?? null
 
-  const { data: workflowMapForLookup = {}, isPending: workflowMapPending } =
-    useWorkflowMap(workspaceId)
-  /** Hydrates workflow-selector values and multi-select workflow dropdowns to names. */
+  const {
+    data: workflowMapForLookup = {},
+    isSuccess: workflowMapLoaded,
+    isPlaceholderData: workflowMapIsPlaceholder,
+  } = useWorkflowMap(workspaceId)
+  /**
+   * Hydrates workflow-selector values and multi-select workflow dropdowns to
+   * names. Ready only on a successful, non-placeholder load — an errored or
+   * stale-placeholder map must not mislabel valid workflows as deleted.
+   */
   const workflowSelectionName = useMemo(() => {
-    const lookup = { workflowMap: workflowMapForLookup, ready: !workflowMapPending }
+    const lookup = {
+      workflowMap: workflowMapForLookup,
+      ready: workflowMapLoaded && !workflowMapIsPlaceholder,
+    }
     return (
       resolveWorkflowSelectionLabel(subBlock, rawValue, lookup) ??
       resolveWorkflowMultiSelectLabel(subBlock, rawValue, lookup)
     )
-  }, [workflowMapForLookup, workflowMapPending, subBlock, rawValue])
+  }, [workflowMapForLookup, workflowMapLoaded, workflowMapIsPlaceholder, subBlock, rawValue])
 
   const { data: mcpServers = [] } = useMcpServers(workspaceId || '')
   const mcpServerDisplayName = useMemo(() => {
@@ -329,26 +338,10 @@ const SubBlockRow = memo(function SubBlockRow({
     [subBlock, rawValue, customTools]
   )
 
-  const filterDisplayValue = useMemo(() => {
-    const isFilterField =
-      subBlock?.id === 'filter' || subBlock?.id === 'filterCriteria' || subBlock?.id === 'sort'
-
-    if (!isFilterField || !rawValue) return null
-
-    const parsedValue = tryParseJson(rawValue)
-
-    if (isPlainObject(parsedValue) || Array.isArray(parsedValue)) {
-      try {
-        const jsonStr = JSON.stringify(parsedValue, null, 0)
-        if (jsonStr.length <= 35) return jsonStr
-        return `${jsonStr.slice(0, 32)}...`
-      } catch {
-        return null
-      }
-    }
-
-    return null
-  }, [subBlock?.id, rawValue])
+  const filterDisplayValue = useMemo(
+    () => resolveFilterFieldLabel(subBlock, rawValue),
+    [subBlock, rawValue]
+  )
 
   /** Hydrates skill references to display names. */
   const { data: workspaceSkills = [] } = useSkills(workspaceId || '')

apps/sim/app/workspace/[workspaceId]/w/components/preview/components/preview-workflow/components/block/block.tsx

@@ -113,11 +113,15 @@ const SubBlockRow = memo(function SubBlockRow({
 
   const workflowLookup = { workflowMap, ready: workflowLabelsReady }
   const dropdownLabel = resolveDropdownLabel(subBlock, rawValue)
-  const variablesDisplay = resolveVariablesLabel(
-    subBlock,
-    rawValue,
-    Object.values(useVariablesStore.getState().variables)
-  )
+  // Materialize the variables store only for variables-input rows.
+  const variablesDisplay =
+    subBlock?.type === 'variables-input'
+      ? resolveVariablesLabel(
+          subBlock,
+          rawValue,
+          Object.values(useVariablesStore.getState().variables)
+        )
+      : null
   // The preview is hook-free, so custom tools referenced only by id resolve
   // through their inline schema/registry fallbacks rather than the API.
   const toolsDisplay = resolveToolsLabel(subBlock, rawValue, [])

apps/sim/app/workspace/[workspaceId]/w/components/preview/components/preview-workflow/preview-workflow.tsx

@@ -234,10 +234,12 @@ export function PreviewWorkflow({
   const workspaceId = propWorkspaceId ?? params.workspaceId
   const {
     data: workflowMap = {},
-    isLoading: isWorkflowMapLoading,
+    isSuccess: isWorkflowMapLoaded,
     isPlaceholderData: isWorkflowMapPlaceholderData,
   } = useWorkflowMap(workspaceId)
-  const workflowLabelsReady = !isWorkflowMapLoading && !isWorkflowMapPlaceholderData
+  // Ready only on a successful, non-placeholder load — an errored or stale
+  // placeholder map must not mislabel valid workflows as deleted.
+  const workflowLabelsReady = isWorkflowMapLoaded && !isWorkflowMapPlaceholderData
   const containerRef = useRef<HTMLDivElement>(null)
   const nodeTypes = previewNodeTypes
   const isValidWorkflowState = workflowState?.blocks && workflowState.edges

apps/sim/lib/workflows/subblocks/display.test.ts

@@ -9,6 +9,8 @@ vi.mock('@/blocks', () => ({
 
 import {
   getDisplayValue,
+  resolveDropdownLabel,
+  resolveFilterFieldLabel,
   resolveSkillsLabel,
   resolveToolsLabel,
   resolveVariablesLabel,
@@ -130,6 +132,37 @@ describe('resolveSkillsLabel', () => {
   })
 })
 
+describe('resolveDropdownLabel', () => {
+  const dropdown = {
+    id: 'mode',
+    type: 'dropdown',
+    options: [{ id: 'opt-1', label: 'Option One' }, 'literal'],
+  } as SubBlockConfig
+
+  it('resolves option ids and string options to labels', () => {
+    expect(resolveDropdownLabel(dropdown, 'opt-1')).toBe('Option One')
+    expect(resolveDropdownLabel(dropdown, 'literal')).toBe('literal')
+    expect(resolveDropdownLabel(dropdown, 'missing')).toBeNull()
+  })
+})
+
+describe('resolveFilterFieldLabel', () => {
+  const filterField = { id: 'filter', type: 'short-input' } as SubBlockConfig
+
+  it('renders compact JSON for filter fields and truncates long values', () => {
+    expect(resolveFilterFieldLabel(filterField, '{"a":1}')).toBe('{"a":1}')
+    const long = JSON.stringify({ column: 'status', operator: 'contains', value: 'running' })
+    expect(resolveFilterFieldLabel(filterField, long)).toBe(`${long.slice(0, 32)}...`)
+  })
+
+  it('returns null for non-filter subblocks and non-JSON values', () => {
+    expect(
+      resolveFilterFieldLabel({ id: 'other', type: 'short-input' } as SubBlockConfig, '{"a":1}')
+    ).toBeNull()
+    expect(resolveFilterFieldLabel(filterField, 'plain text')).toBeNull()
+  })
+})
+
 describe('getDisplayValue', () => {
   it('handles empty, scalar, and object values', () => {
     expect(getDisplayValue(null)).toBe('-')

apps/sim/lib/workflows/subblocks/display.ts

@@ -76,12 +76,12 @@ const isFieldFormatArray = (value: unknown): value is FieldFormat[] => {
 }
 
 /** Checks if a value is a plain object (not array, not null). */
-export const isPlainObject = (value: unknown): value is Record<string, unknown> => {
+const isPlainObject = (value: unknown): value is Record<string, unknown> => {
   return typeof value === 'object' && value !== null && !Array.isArray(value)
 }
 
 /** Type guard for variable assignments arrays (variables-input subblocks). */
-export const isVariableAssignmentsArray = (
+const isVariableAssignmentsArray = (
   value: unknown
 ): value is Array<{ id?: string; variableId?: string; variableName?: string; value: unknown }> => {
   return (
@@ -167,7 +167,7 @@ const isSortConditionArray = (value: unknown): value is SortRule[] => {
  * Attempts to parse a JSON string, returning the parsed value or the
  * original value if parsing fails.
  */
-export const tryParseJson = (value: unknown): unknown => {
+const tryParseJson = (value: unknown): unknown => {
   if (typeof value !== 'string') return value
   try {
     const trimmed = value.trim()
@@ -320,11 +320,35 @@ export const getDisplayValue = (value: unknown): string => {
  * `ready` gates resolution so missing entries only render as deleted once
  * the lookup has actually loaded.
  */
-export interface WorkflowNameLookup {
+interface WorkflowNameLookup {
   workflowMap: Record<string, { name: string }>
   ready: boolean
 }
 
+/**
+ * Resolves filter/sort builder subblocks to a compact single-line JSON
+ * preview. Returns null for other subblocks; callers use a non-null result
+ * to apply monospace styling.
+ */
+export function resolveFilterFieldLabel(
+  subBlock: SubBlockConfig | undefined,
+  rawValue: unknown
+): string | null {
+  const isFilterField =
+    subBlock?.id === 'filter' || subBlock?.id === 'filterCriteria' || subBlock?.id === 'sort'
+  if (!isFilterField || !rawValue) return null
+
+  const parsedValue = tryParseJson(rawValue)
+  if (!isPlainObject(parsedValue) && !Array.isArray(parsedValue)) return null
+
+  try {
+    const jsonStr = JSON.stringify(parsedValue, null, 0)
+    return jsonStr.length <= 35 ? jsonStr : truncate(jsonStr, 32)
+  } catch {
+    return null
+  }
+}
+
 /**
  * Resolves a static dropdown/combobox value to its option label.
  * Returns null if not a dropdown/combobox or no matching option is found.

apps/sim/lib/workspace-events/subscriptions.test.ts

@@ -60,4 +60,16 @@ describe('parseSubscriptionConfig', () => {
     expect(config?.errorCountThreshold).toBe(1000)
     expect(config?.inactivityHours).toBe(1)
   })
+
+  it('rounds fractional integer fields (counts feed SQL LIMIT) but keeps credits fractional', () => {
+    const config = parseSubscriptionConfig({
+      eventType: 'consecutive_failures',
+      consecutiveFailures: '2.5',
+      windowHours: 12.4,
+      costThresholdCredits: 250.5,
+    })
+    expect(config?.consecutiveFailures).toBe(3)
+    expect(config?.windowHours).toBe(12)
+    expect(config?.costThresholdCredits).toBe(250.5)
+  })
 })

apps/sim/lib/workspace-events/subscriptions.ts

@@ -66,28 +66,31 @@ function parseStringArray(value: unknown): string[] {
  * Per-field bounds ported from the legacy notifications contract. Rule SQL
  * runs on the execution-completion hot path, so windows and counts must stay
  * inside the designed envelope regardless of what the free-text subblocks
- * contain. The credit bounds are the legacy dollar bounds ($0.01-$1000) at
- * 200 credits per dollar.
+ * contain. Integer fields are rounded — counts feed SQL LIMIT, which rejects
+ * fractional values. The credit bounds are the legacy dollar bounds
+ * ($0.01-$1000) at 200 credits per dollar; credits stay fractional like the
+ * legacy dollar threshold.
  */
 const SIM_RULE_BOUNDS = {
-  consecutiveFailures: { min: 1, max: 100 },
-  failureRatePercent: { min: 1, max: 100 },
-  windowHours: { min: 1, max: 168 },
-  durationThresholdMs: { min: 1000, max: 3_600_000 },
-  latencySpikePercent: { min: 10, max: 1000 },
+  consecutiveFailures: { min: 1, max: 100, integer: true },
+  failureRatePercent: { min: 1, max: 100, integer: true },
+  windowHours: { min: 1, max: 168, integer: true },
+  durationThresholdMs: { min: 1000, max: 3_600_000, integer: true },
+  latencySpikePercent: { min: 10, max: 1000, integer: true },
   costThresholdCredits: { min: 2, max: 200_000 },
-  errorCountThreshold: { min: 1, max: 1000 },
-  inactivityHours: { min: 1, max: 168 },
+  errorCountThreshold: { min: 1, max: 1000, integer: true },
+  inactivityHours: { min: 1, max: 168, integer: true },
 } as const
 
 function parseBoundedNumber(
   value: unknown,
   fallback: number,
-  bounds: { min: number; max: number }
+  bounds: { min: number; max: number; integer?: boolean }
 ): number {
   const parsed = typeof value === 'number' ? value : Number(value)
   if (!Number.isFinite(parsed) || parsed <= 0) return fallback
-  return Math.min(Math.max(parsed, bounds.min), bounds.max)
+  const clamped = Math.min(Math.max(parsed, bounds.min), bounds.max)
+  return bounds.integer ? Math.round(clamped) : clamped
 }
 
 /**

apps/sim/triggers/sim/workspace-event.ts

@@ -69,7 +69,8 @@ export const simWorkspaceEventTrigger: TriggerConfig = {
       type: 'short-input',
       placeholder: String(SIM_RULE_DEFAULTS.failureRatePercent),
       defaultValue: String(SIM_RULE_DEFAULTS.failureRatePercent),
-      description: 'Fire when the failure rate exceeds this percentage over the time window.',
+      description:
+        'Fire when the failure rate meets or exceeds this percentage over the time window.',
       required: { field: 'eventType', value: 'failure_rate' },
       mode: 'trigger',
       condition: { field: 'eventType', value: 'failure_rate' },
@@ -114,7 +115,7 @@ export const simWorkspaceEventTrigger: TriggerConfig = {
       type: 'short-input',
       placeholder: String(SIM_RULE_DEFAULTS.errorCountThreshold),
       defaultValue: String(SIM_RULE_DEFAULTS.errorCountThreshold),
-      description: 'Fire when this many errors occur within the time window.',
+      description: 'Fire when at least this many errors occur within the time window.',
       required: { field: 'eventType', value: 'error_count' },
       mode: 'trigger',
       condition: { field: 'eventType', value: 'error_count' },