fix(servicenow): drop redundant hidden fileContent param from upload attachment

Per project rule, visibility:'hidden' is reserved for framework-injected
tokens, not user-supplied data. fileContent was a copied-over legacy
fallback with no caller (the block uploads via the canonical file/UserFile
path), so remove it from the tool, types, contract, and route.

Author: waleedlatif1

apps/sim/app/api/tools/servicenow/upload-attachment/route.ts

@@ -35,34 +35,26 @@ export const POST = withRouteHandler(async (request: NextRequest) => {
     if (!parsed.success) return parsed.response
     const body = parsed.data.body
 
-    let fileBuffer: Buffer
-    let contentType = 'application/octet-stream'
-
-    if (body.file) {
-      let userFile
-      try {
-        userFile = processSingleFileToUserFile(body.file, requestId, logger)
-      } catch (error) {
-        return NextResponse.json(
-          { success: false, error: getErrorMessage(error, 'Failed to process file') },
-          { status: 400 }
-        )
-      }
-
-      const denied = await assertToolFileAccess(userFile.key, authResult.userId, requestId, logger)
-      if (denied) return denied
+    if (!body.file) {
+      return NextResponse.json({ success: false, error: 'A file is required' }, { status: 400 })
+    }
 
-      if (userFile.type) contentType = userFile.type
-      fileBuffer = await downloadFileFromStorage(userFile, requestId, logger)
-    } else if (body.fileContent) {
-      fileBuffer = Buffer.from(body.fileContent, 'base64')
-    } else {
+    let userFile
+    try {
+      userFile = processSingleFileToUserFile(body.file, requestId, logger)
+    } catch (error) {
       return NextResponse.json(
-        { success: false, error: 'Either file or fileContent must be provided' },
+        { success: false, error: getErrorMessage(error, 'Failed to process file') },
         { status: 400 }
       )
     }
 
+    const denied = await assertToolFileAccess(userFile.key, authResult.userId, requestId, logger)
+    if (denied) return denied
+
+    const contentType = userFile.type || 'application/octet-stream'
+    const fileBuffer = await downloadFileFromStorage(userFile, requestId, logger)
+
     const baseUrl = body.instanceUrl.trim().replace(/\/$/, '')
     const uploadParams = new URLSearchParams({
       table_name: body.tableName.trim(),

apps/sim/lib/api/contracts/tools/servicenow.ts

@@ -10,7 +10,6 @@ export const servicenowUploadAttachmentBodySchema = z.object({
   recordSysId: z.string().min(1, 'Record sys_id is required'),
   fileName: z.string().min(1, 'File name is required'),
   file: RawFileInputSchema.optional().nullable(),
-  fileContent: z.string().optional().nullable(),
 })
 
 export type ServiceNowUploadAttachmentBody = z.input<typeof servicenowUploadAttachmentBodySchema>

apps/sim/tools/servicenow/types.ts

@@ -152,7 +152,6 @@ export interface ServiceNowUploadAttachmentParams {
   recordSysId: string
   fileName: string
   file?: unknown
-  fileContent?: string
 }
 
 export interface ServiceNowUploadAttachmentResponse extends ToolResponse {

apps/sim/tools/servicenow/upload_attachment.ts

@@ -59,12 +59,6 @@ export const uploadAttachmentTool: ToolConfig<
       visibility: 'user-only',
       description: 'File to upload (UserFile object)',
     },
-    fileContent: {
-      type: 'string',
-      required: false,
-      visibility: 'hidden',
-      description: 'Base64-encoded file content (legacy)',
-    },
   },
 
   request: {
@@ -81,7 +75,6 @@ export const uploadAttachmentTool: ToolConfig<
       recordSysId: params.recordSysId,
       fileName: params.fileName,
       file: params.file,
-      fileContent: params.fileContent,
     }),
   },