fix(metrics): skip zero-ms fallback duration and gate stale-cleanup metric on actual row transition

Author: TheodoreSpeaks

apps/sim/app/api/cron/cleanup-stale-executions/route.ts

@@ -55,7 +55,10 @@ export const GET = withRouteHandler(async (request: NextRequest) => {
         const staleDurationMinutes = Math.round(staleDurationMs / 60000)
         const totalDurationMs = Math.min(staleDurationMs, MAX_INT32)
 
-        await db
+        // Conditional on status='running' so a worker that completes between the
+        // select and this update keeps its own terminal status (and its own
+        // ExecutionCompleted point) — no force-fail overwrite, no double count.
+        const transitioned = await db
           .update(workflowExecutionLogs)
           .set({
             status: 'failed',
@@ -67,7 +70,20 @@ export const GET = withRouteHandler(async (request: NextRequest) => {
               to_jsonb(${`Execution terminated: worker timeout or crash after ${staleDurationMinutes} minutes`}::text)
             )`,
           })
-          .where(eq(workflowExecutionLogs.id, execution.id))
+          .where(
+            and(
+              eq(workflowExecutionLogs.id, execution.id),
+              eq(workflowExecutionLogs.status, 'running')
+            )
+          )
+          .returning({ id: workflowExecutionLogs.id })
+
+        if (transitioned.length === 0) {
+          logger.info(`Skipped stale execution ${execution.executionId}: no longer running`, {
+            workflowId: execution.workflowId,
+          })
+          continue
+        }
 
         logger.info(`Cleaned up stale execution ${execution.executionId}`, {
           workflowId: execution.workflowId,

apps/sim/lib/logs/execution/logging-session.ts

@@ -1077,7 +1077,7 @@ export class LoggingSession {
       } else {
         this.emitExecutionCompletedMetric(
           params.status === 'failed' || params.status === 'cancelled' ? params.status : 'success',
-          params.totalDurationMs || 0
+          params.totalDurationMs
         )
       }