Skip to content

Commit b9d3558

Browse files
committed
fix(salesforce): trim echoed output IDs and relation reference IDs
- update/delete tools now return output.id from the trimmed ID so chained workflows never receive whitespace-padded IDs - trim relation reference IDs (AccountId, ContactId, WhoId, WhatId) in create/update bodies to avoid Salesforce reference errors from copy-pasted whitespace
1 parent a0c593f commit b9d3558

16 files changed

Lines changed: 23 additions & 23 deletions

apps/sim/tools/salesforce/create_case.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,8 @@ export const salesforceCreateCaseTool: ToolConfig<
9393
if (params.status) body.Status = params.status
9494
if (params.priority) body.Priority = params.priority
9595
if (params.origin) body.Origin = params.origin
96-
if (params.contactId) body.ContactId = params.contactId
97-
if (params.accountId) body.AccountId = params.accountId
96+
if (params.contactId) body.ContactId = params.contactId.trim()
97+
if (params.accountId) body.AccountId = params.accountId.trim()
9898
if (params.description) body.Description = params.description
9999
return body
100100
},

apps/sim/tools/salesforce/create_contact.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ export const salesforceCreateContactTool: ToolConfig<
115115
if (params.firstName) body.FirstName = params.firstName
116116
if (params.email) body.Email = params.email
117117
if (params.phone) body.Phone = params.phone
118-
if (params.accountId) body.AccountId = params.accountId
118+
if (params.accountId) body.AccountId = params.accountId.trim()
119119
if (params.title) body.Title = params.title
120120
if (params.department) body.Department = params.department
121121
if (params.mailingStreet) body.MailingStreet = params.mailingStreet

apps/sim/tools/salesforce/create_opportunity.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ export const salesforceCreateOpportunityTool: ToolConfig<
8585
StageName: params.stageName,
8686
CloseDate: params.closeDate,
8787
}
88-
if (params.accountId) body.AccountId = params.accountId
88+
if (params.accountId) body.AccountId = params.accountId.trim()
8989
if (params.amount) body.Amount = Number.parseFloat(params.amount)
9090
if (params.probability) body.Probability = Number.parseInt(params.probability)
9191
if (params.description) body.Description = params.description

apps/sim/tools/salesforce/create_task.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,8 @@ export const salesforceCreateTaskTool: ToolConfig<
9393
if (params.status) body.Status = params.status
9494
if (params.priority) body.Priority = params.priority
9595
if (params.activityDate) body.ActivityDate = params.activityDate
96-
if (params.whoId) body.WhoId = params.whoId
97-
if (params.whatId) body.WhatId = params.whatId
96+
if (params.whoId) body.WhoId = params.whoId.trim()
97+
if (params.whatId) body.WhatId = params.whatId.trim()
9898
if (params.description) body.Description = params.description
9999
return body
100100
},

apps/sim/tools/salesforce/delete_account.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ export const salesforceDeleteAccountTool: ToolConfig<
7474
return {
7575
success: true,
7676
output: {
77-
id: params?.accountId || '',
77+
id: params?.accountId?.trim() || '',
7878
deleted: true,
7979
},
8080
}

apps/sim/tools/salesforce/delete_case.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ export const salesforceDeleteCaseTool: ToolConfig<
6363
return {
6464
success: true,
6565
output: {
66-
id: params?.caseId || '',
66+
id: params?.caseId?.trim() || '',
6767
deleted: true,
6868
},
6969
}

apps/sim/tools/salesforce/delete_contact.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ export const salesforceDeleteContactTool: ToolConfig<
5656
return {
5757
success: true,
5858
output: {
59-
id: params?.contactId || '',
59+
id: params?.contactId?.trim() || '',
6060
deleted: true,
6161
},
6262
}

apps/sim/tools/salesforce/delete_lead.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ export const salesforceDeleteLeadTool: ToolConfig<
4949
return {
5050
success: true,
5151
output: {
52-
id: params?.leadId || '',
52+
id: params?.leadId?.trim() || '',
5353
deleted: true,
5454
},
5555
}

apps/sim/tools/salesforce/delete_opportunity.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ export const salesforceDeleteOpportunityTool: ToolConfig<
5353
return {
5454
success: true,
5555
output: {
56-
id: params?.opportunityId || '',
56+
id: params?.opportunityId?.trim() || '',
5757
deleted: true,
5858
},
5959
}

apps/sim/tools/salesforce/delete_task.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ export const salesforceDeleteTaskTool: ToolConfig<
6363
return {
6464
success: true,
6565
output: {
66-
id: params?.taskId || '',
66+
id: params?.taskId?.trim() || '',
6767
deleted: true,
6868
},
6969
}

0 commit comments

Comments
 (0)