simplify(scheduled-tasks): reuse date-fns for launch/end math; drop dead 'running' status + single-use helper

Author: waleedlatif1

apps/sim/app/workspace/[workspaceId]/scheduled-tasks/components/task-details-modal/task-details-modal.tsx

@@ -16,13 +16,12 @@ import type {
 
 /**
  * Plaintext copy per task state: the status label and the verb that titles the
- * run-time field — the tense carries the state ("Started" is in flight, "Ran"
- * is done). No icons, no status colors, by design. Total over the status union
- * for type safety, though `pending` tasks open the edit `TaskModal` instead.
+ * run-time field — the tense carries the state ("Ran" is done, "Failed" errored).
+ * No icons, no status colors, by design. Total over the status union for type
+ * safety, though `pending` tasks open the edit `TaskModal` instead.
  */
 const STATUS_COPY: Record<ScheduledTaskStatus, { label: string; timeTitle: string }> = {
   pending: { label: 'Pending', timeTitle: 'Runs' },
-  running: { label: 'Running', timeTitle: 'Started' },
   error: { label: 'Error', timeTitle: 'Failed' },
   completed: { label: 'Completed', timeTitle: 'Ran' },
 }

apps/sim/app/workspace/[workspaceId]/scheduled-tasks/components/task-modal/task-modal.tsx

@@ -1,7 +1,7 @@
 'use client'
 
 import { useEffect, useState } from 'react'
-import { format, isSameDay } from 'date-fns'
+import { addHours, format, isSameDay, startOfHour } from 'date-fns'
 import { useParams } from 'next/navigation'
 import {
   Calendar,
@@ -34,14 +34,6 @@ function isLaunchInPast(launchDate: string, launchTime: string): boolean {
   return new Date(`${launchDate}T${launchTime}`) < new Date()
 }
 
-/** The next top of the hour from `from` (rolling to the next day at 23:xx). */
-function nextHour(from: Date): Date {
-  const next = new Date(from)
-  next.setMinutes(0, 0, 0)
-  next.setHours(next.getHours() + 1)
-  return next
-}
-
 /**
  * Seeds the launch date/time for a create. A clicked time slot uses it
  * verbatim; otherwise the default lands on a valid future instant — the next
@@ -53,7 +45,7 @@ function defaultLaunch(slot: CalendarSlot | null | undefined): { date: string; t
   const now = new Date()
   const day = slot?.date ?? now
   const base = isSameDay(day, now)
-    ? nextHour(now)
+    ? addHours(startOfHour(now), 1)
     : new Date(`${format(day, 'yyyy-MM-dd')}T${DEFAULT_TIME}`)
   return { date: format(base, 'yyyy-MM-dd'), time: format(base, 'HH:mm') }
 }

apps/sim/app/workspace/[workspaceId]/scheduled-tasks/utils/recurrence.test.ts

@@ -1,3 +1,4 @@
+import { endOfDay } from 'date-fns'
 import { describe, expect, it } from 'vitest'
 import {
   cronToRecurrence,
@@ -81,7 +82,7 @@ describe('recurrenceToScheduleFields', () => {
       '2026-06-15',
       '09:00'
     )
-    expect(fields.endsAt).toBe(new Date('2026-07-01T23:59:59').toISOString())
+    expect(fields.endsAt).toBe(endOfDay(new Date('2026-07-01T00:00')).toISOString())
     expect(fields.maxRuns).toBeUndefined()
     expect(fields.lifecycle).toBe('persistent')
   })

apps/sim/app/workspace/[workspaceId]/scheduled-tasks/utils/recurrence.ts

@@ -1,5 +1,5 @@
 import { Cron } from 'croner'
-import { format } from 'date-fns'
+import { endOfDay, format } from 'date-fns'
 
 /**
  * Recurrence cadence the modal exposes. `once` is a one-time launch; `custom`
@@ -37,11 +37,6 @@ function localDateTime(date: string, time: string): Date {
   return new Date(`${date}T${time}`)
 }
 
-/** The launch instant as an ISO 8601 string, for one-time scheduling. */
-export function launchInstantIso(date: string, time: string): string {
-  return localDateTime(date, time).toISOString()
-}
-
 /**
  * Builds the cron expression for a recurrence, evaluated in the schedule's
  * timezone against the launch day/time. Returns `null` for a one-time task and
@@ -92,7 +87,7 @@ export function recurrenceToScheduleFields(
   if (!cronExpression) {
     return {
       cronExpression: null,
-      time: launchInstantIso(launchDate, launchTime),
+      time: localDateTime(launchDate, launchTime).toISOString(),
       lifecycle: 'persistent',
     }
   }
@@ -101,7 +96,8 @@ export function recurrenceToScheduleFields(
   return {
     cronExpression,
     maxRuns: end.type === 'after' ? end.count : undefined,
-    endsAt: end.type === 'on' ? new Date(`${end.date}T23:59:59`).toISOString() : undefined,
+    endsAt:
+      end.type === 'on' ? endOfDay(localDateTime(end.date, '00:00')).toISOString() : undefined,
     lifecycle: end.type === 'after' ? 'until_complete' : 'persistent',
   }
 }

apps/sim/app/workspace/[workspaceId]/scheduled-tasks/utils/schedule-events.test.ts

@@ -68,7 +68,7 @@ describe('taskToCalendarEvent', () => {
   })
 
   it('derives the same event shape for every status', () => {
-    const statuses = ['pending', 'running', 'error', 'completed'] as const
+    const statuses = ['pending', 'error', 'completed'] as const
     const titles = statuses.map((status) => taskToCalendarEvent(makeTask({ status })).title)
     expect(new Set(titles).size).toBe(1)
   })

apps/sim/app/workspace/[workspaceId]/scheduled-tasks/utils/schedule-events.ts

@@ -5,10 +5,10 @@ import { expandOccurrences } from '@/app/workspace/[workspaceId]/scheduled-tasks
 import type { ChatContext } from '@/stores/panel'
 
 /**
- * Lifecycle of a scheduled task occurrence: `pending` has not run yet, `running`
- * is executing now, and `error`/`completed` are terminal outcomes of a past run.
+ * Lifecycle of a scheduled task occurrence: `pending` has not run yet, and
+ * `error`/`completed` are terminal outcomes of a past run.
  */
-export type ScheduledTaskStatus = 'pending' | 'running' | 'error' | 'completed'
+export type ScheduledTaskStatus = 'pending' | 'error' | 'completed'
 
 /**
  * One occurrence of a scheduled task as the calendar renders it. A recurring