Updates

Author: Sg312

apps/sim/lib/copilot/request/tools/executor.ts

@@ -9,10 +9,7 @@ import {
   markAsyncToolRunning,
   upsertAsyncToolCall,
 } from '@/lib/copilot/async-runs/repository'
-import {
-  TOOL_WATCHDOG_DEFAULT_MS,
-  TOOL_WATCHDOG_LONG_RUNNING_MS,
-} from '@/lib/copilot/constants'
+import { TOOL_WATCHDOG_DEFAULT_MS, TOOL_WATCHDOG_LONG_RUNNING_MS } from '@/lib/copilot/constants'
 import {
   MothershipStreamV1AsyncToolRecordStatus,
   MothershipStreamV1EventType,

apps/sim/lib/copilot/vfs/workflow-alias-backing.ts

@@ -1,7 +1,5 @@
 import { db } from '@sim/db'
 import { workspaceFileFolder, workspaceFiles } from '@sim/db/schema'
-import { createLogger } from '@sim/logger'
-import { toError } from '@sim/utils/errors'
 import { and, eq, inArray, isNull } from 'drizzle-orm'
 import {
   WORKFLOW_CHANGELOG_BACKING_FOLDER,
@@ -19,8 +17,6 @@ import {
   type WorkspaceFileRecord,
 } from '@/lib/uploads/contexts/workspace/workspace-file-manager'
 
-const logger = createLogger('WorkflowAliasBacking')
-
 export interface WorkflowAliasBacking {
   changelogFolderId: string
   plansRootFolderId: string
@@ -97,24 +93,6 @@ export async function ensureWorkflowAliasBacking(args: {
   }
 }
 
-export async function ensureWorkflowAliasBackingQuietly(args: {
-  workspaceId: string
-  userId: string
-  workflowId: string
-  workflowName?: string
-}): Promise<WorkflowAliasBacking | null> {
-  try {
-    return await ensureWorkflowAliasBacking(args)
-  } catch (error) {
-    logger.warn('Failed to ensure workflow alias backing', {
-      workspaceId: args.workspaceId,
-      workflowId: args.workflowId,
-      error: toError(error).message,
-    })
-    return null
-  }
-}
-
 export async function ensureWorkspacePlanBacking(args: {
   workspaceId: string
   userId: string

apps/sim/lib/copilot/vfs/workspace-vfs.ts

@@ -75,7 +75,6 @@ import {
   serializeVersions,
   serializeWorkflowMeta,
 } from '@/lib/copilot/vfs/serializers'
-import { ensureWorkflowAliasBackingQuietly } from '@/lib/copilot/vfs/workflow-alias-backing'
 import {
   buildWorkflowAliasLinks,
   isWorkflowAliasBackingPath,
@@ -984,18 +983,12 @@ export class WorkspaceVFS {
 
     const folderPaths = this.buildFolderPaths(folderRows)
 
-    if (workflowArtifactsEnabled) {
-      await Promise.all(
-        workflowRows.map((wf) =>
-          ensureWorkflowAliasBackingQuietly({
-            workspaceId,
-            userId,
-            workflowId: wf.id,
-            workflowName: wf.name,
-          })
-        )
-      )
-    }
+    // NOTE: materialization is a pure READ. Alias backing (changelog/plan
+    // folders + files) is ensured at write time — workflow create/rename
+    // (lib/workflows/utils) and alias writes (vfs/resource-writer,
+    // tools/server/files/workspace-file) — never here. Ensuring per workflow
+    // on every materialize meant N storage/DB writes per read tool call, and
+    // concurrent materializations contending on the same rows.
     const workspaceFiles = workflowArtifactsEnabled
       ? await listWorkspaceFiles(workspaceId, { includeReservedSystemFiles: true })
       : []