From c0849e34a837061b087c300b8f0f7d472f39c989 Mon Sep 17 00:00:00 2001 From: Piyush Vyas Date: Sun, 22 Feb 2026 12:58:26 -0600 Subject: [PATCH] Fix code review suggestions: changelog, stale refs, hardcoded count, unpinned version - Add missing CHANGELOG 0.2.0 entry documenting jq-to-node migration and marketplace submission - Remove references to nonexistent /skill-tools:validate and /skill-tools:score slash commands - Remove hardcoded "9 rules" count from hook success message to avoid staleness on rule additions - Pin skill-tools version in skill-quality examples to @0.2.2 instead of @latest --- CHANGELOG.md | 11 +++++++++++ hooks/post-write-lint.sh | 2 +- skills/skill-quality/SKILL.md | 8 ++++---- 3 files changed, 16 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 93bb7c1..352323f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,16 @@ # Changelog +## 0.2.0 — 2026-02-20 + +### Changed +- Replace jq with Node.js for all JSON parsing in hook and tests — eliminates the jq dependency (node is already required for npx) +- Remove jq check from setup.sh dependency checker +- Clean up plugin.json for marketplace submission: add homepage field, add version field (CLI validator recommends it) +- Strengthen command instructions to prevent local repo substitution + +### Added +- Submitted to claude-plugins-official marketplace + ## 0.1.1 — 2026-02-13 ### Changed diff --git a/hooks/post-write-lint.sh b/hooks/post-write-lint.sh index bf99818..09ede94 100755 --- a/hooks/post-write-lint.sh +++ b/hooks/post-write-lint.sh @@ -74,7 +74,7 @@ LINT_JSON="$LINT_JSON" SKILL_DIR="$SKILL_DIR" node -e " let summary; if (diags.length === 0) { - summary = 'skill-tools lint: all 9 rules passed for ' + dir + '/SKILL.md'; + summary = 'skill-tools lint: all rules passed for ' + dir + '/SKILL.md'; } else { const msgs = diags.map(d => ' [' + d.severity + '] ' + (d.ruleId || 'unknown') + ': ' + d.message diff --git a/skills/skill-quality/SKILL.md b/skills/skill-quality/SKILL.md index 3d52b64..917dfae 100644 --- a/skills/skill-quality/SKILL.md +++ b/skills/skill-quality/SKILL.md @@ -107,16 +107,16 @@ Run the quality tools to catch issues before they bite you: ```bash # Quick spec check — does the file parse correctly? -npx --yes skill-tools@latest validate ./my-skill/SKILL.md +npx --yes skill-tools@0.2.2 validate ./my-skill/SKILL.md # Quality lint — description, examples, error handling, headings -npx --yes skill-tools@latest lint ./my-skill/SKILL.md +npx --yes skill-tools@0.2.2 lint ./my-skill/SKILL.md # Full picture — validate + lint + score in one pass -npx --yes skill-tools@latest check ./my-skill/SKILL.md +npx --yes skill-tools@0.2.2 check ./my-skill/SKILL.md ``` -Or use the slash commands: `/skill-tools:validate`, `/skill-tools:lint`, `/skill-tools:score`, `/skill-tools:check`. +Or use the slash commands: `/skill-tools:lint`, `/skill-tools:check`. ## Common Fixes