Non-Blocking Review Concern: Documentation files still contain example values matching sanitized PII defaults
Source: pre-push whole-codebase review
Location: docs/configuration.md:16-19, docs/environment-variables.md:29-34, docs/setup/prep-airdrop.md:210
Date: 2026-04-07
What was flagged
The config template was sanitized to use generic placeholders (Your-Vault-Name, Your-AppleID-Item, etc.), but documentation files still show the original default values ("personal", "Apple", "Synology NAS - TimeMachine", "SSH Keys"). While these appear as documentation examples rather than active configuration, they undermine the sanitization goal if the intent is to remove all traces of specific 1Password vault/item names before making the repo public. Consider updating these docs to use the same generic placeholders as the template.
Context
This issue was automatically created from a non-blocking concern identified
during pre-push whole-codebase review. It was flagged for tracking.
Created by lib-review-issues.sh
Non-Blocking Review Concern: Documentation files still contain example values matching sanitized PII defaults
Source: pre-push whole-codebase review
Location:
docs/configuration.md:16-19, docs/environment-variables.md:29-34, docs/setup/prep-airdrop.md:210Date: 2026-04-07
What was flagged
The config template was sanitized to use generic placeholders (
Your-Vault-Name,Your-AppleID-Item, etc.), but documentation files still show the original default values ("personal","Apple","Synology NAS - TimeMachine","SSH Keys"). While these appear as documentation examples rather than active configuration, they undermine the sanitization goal if the intent is to remove all traces of specific 1Password vault/item names before making the repo public. Consider updating these docs to use the same generic placeholders as the template.Context
This issue was automatically created from a non-blocking concern identified
during pre-push whole-codebase review. It was flagged for tracking.
Created by lib-review-issues.sh