Skip to content

refactor: migrate avoid_returning_widgets rule#243

Draft
andrew-bekhiet-solid wants to merge 1 commit into
implementation-of-parameter-parserfrom
migrate/avoid_returning_widgets
Draft

refactor: migrate avoid_returning_widgets rule#243
andrew-bekhiet-solid wants to merge 1 commit into
implementation-of-parameter-parserfrom
migrate/avoid_returning_widgets

Conversation

@andrew-bekhiet-solid

Copy link
Copy Markdown
Collaborator

feat: also check FunctionDeclarationStatement

feat: also check FunctionDeclarationStatement
@andrew-bekhiet-solid andrew-bekhiet-solid marked this pull request as draft June 8, 2026 18:05

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the AvoidReturningWidgetsRule to utilize the new analyzer-based rule APIs, introducing a dedicated AvoidReturningWidgetsVisitor and adding comprehensive unit tests. Additionally, it registers the rule in the main plugin entry point and cleans up unused dependencies in pubspec.yaml. A critical issue was identified in excluded_identifiers_list_parameter.dart where accessing classDeclaration.namePart will cause a compilation error because namePart does not exist on ClassDeclaration; a suggestion was provided to use classDeclaration.name.lexeme instead.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread lib/src/common/parameters/excluded_identifiers_list_parameter.dart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant