Improve parenting for property definitions

The parent of a property in a property definition isn't the parent in
the AST.

Take this example:
```js
obj.property = {a: 3}
```

Previously `property`'s parent would be the `obj.property`
`PropertyAccessExpression` node and `a`'s parent would be the
`BinaryExpression` node.

Neither of them really are symbols. Instead `property`'s parent should
be `obj` ie the `expression` of the `PropertyAccessExpression` node
and `a`'s parent should be `obj.property` ie the `left` part of the
`BinaryExpression` node.

Author: nicolas-guichard

snapshots/output/pure-js/src/main.js

@@ -110,20 +110,20 @@ function SomeClass() {}
 
 SomeClass.prototype = {
 //^^^^^^^^ reference pure-js 1.0.0 src/`main.js`/SomeClass().
-//        ^^^^^^^^^ definition local 8
+//        ^^^^^^^^^ definition pure-js 1.0.0 src/`main.js`/SomeClass().prototype.
   someMethod() {},
-//^^^^^^^^^^ definition local 9
+//^^^^^^^^^^ definition pure-js 1.0.0 src/`main.js`/SomeClass().prototype.someMethod().
 }
 
 SomeClass.prototype.someMethod2 = () => {}
 //^^^^^^^^ reference pure-js 1.0.0 src/`main.js`/SomeClass().
-//        ^^^^^^^^^ reference local 8
-//                  ^^^^^^^^^^^ definition local 11
+//        ^^^^^^^^^ reference pure-js 1.0.0 src/`main.js`/SomeClass().prototype.
+//                  ^^^^^^^^^^^ definition pure-js 1.0.0 src/`main.js`/SomeClass().prototype.someMethod2.
 
 new SomeClass().someMethod()
 //  ^^^^^^^^^ reference pure-js 1.0.0 src/`main.js`/SomeClass().
-//              ^^^^^^^^^^ reference local 9
+//              ^^^^^^^^^^ reference pure-js 1.0.0 src/`main.js`/SomeClass().prototype.someMethod().
 new SomeClass().someMethod2()
 //  ^^^^^^^^^ reference pure-js 1.0.0 src/`main.js`/SomeClass().
-//              ^^^^^^^^^^^ reference local 11
+//              ^^^^^^^^^^^ reference pure-js 1.0.0 src/`main.js`/SomeClass().prototype.someMethod2.
 

snapshots/output/syntax/src/object-literals-arrow-function.ts

@@ -32,17 +32,17 @@ export function consumesArrowFunction(): number {
   return (
     hasArrowFunctionParameter(1, ({ foobar }) => ({ foobar: foobar + 1 }))
 //  ^^^^^^^^^^^^^^^^^^^^^^^^^ reference syntax 1.0.0 src/`object-literals-arrow-function.ts`/hasArrowFunctionParameter().
-//                                  ^^^^^^ definition local 4
+//                                  ^^^^^^ definition local 8
 //                                  ^^^^^^ reference syntax 1.0.0 src/`object-literals-arrow-function.ts`/Foobar#foobar.
 //                                                  ^^^^^^ reference syntax 1.0.0 src/`object-literals-arrow-function.ts`/Foobar#foobar.
-//                                                          ^^^^^^ reference local 4
+//                                                          ^^^^^^ reference local 8
       .foobar +
 //     ^^^^^^ reference syntax 1.0.0 src/`object-literals-arrow-function.ts`/Foobar#foobar.
     hasArrowFunctionParameter(2, foobar => ({ foobar: foobar.foobar + 2 }))
 //  ^^^^^^^^^^^^^^^^^^^^^^^^^ reference syntax 1.0.0 src/`object-literals-arrow-function.ts`/hasArrowFunctionParameter().
-//                               ^^^^^^ definition local 6
+//                               ^^^^^^ definition local 11
 //                                            ^^^^^^ reference syntax 1.0.0 src/`object-literals-arrow-function.ts`/Foobar#foobar.
-//                                                    ^^^^^^ reference local 6
+//                                                    ^^^^^^ reference local 11
 //                                                           ^^^^^^ reference syntax 1.0.0 src/`object-literals-arrow-function.ts`/Foobar#foobar.
       .foobar
 //     ^^^^^^ reference syntax 1.0.0 src/`object-literals-arrow-function.ts`/Foobar#foobar.
@@ -55,9 +55,9 @@ export function genericArrow(): Foobar[] {
   return [1].map<Foobar>(n => ({ foobar: n + 1 }))
 //           ^^^ reference typescript 5.9.3 lib/`lib.es5.d.ts`/Array#map().
 //               ^^^^^^ reference syntax 1.0.0 src/`object-literals-arrow-function.ts`/Foobar#
-//                       ^ definition local 10
+//                       ^ definition local 15
 //                               ^^^^^^ reference syntax 1.0.0 src/`object-literals-arrow-function.ts`/Foobar#foobar.
-//                                       ^ reference local 10
+//                                       ^ reference local 15
 }
 
 export function genericArrowOption(): Option<Foobar>[] {
@@ -68,10 +68,10 @@ export function genericArrowOption(): Option<Foobar>[] {
 //           ^^^ reference typescript 5.9.3 lib/`lib.es5.d.ts`/Array#map().
 //               ^^^^^^ reference syntax 1.0.0 src/`reusable-types.ts`/Option#
 //                      ^^^^^^ reference syntax 1.0.0 src/`object-literals-arrow-function.ts`/Foobar#
-//                               ^ definition local 14
+//                               ^ definition local 19
 //                                       ^^^^^ reference syntax 1.0.0 src/`reusable-types.ts`/Option#value.
 //                                                ^^^^^^ reference syntax 1.0.0 src/`object-literals-arrow-function.ts`/Foobar#foobar.
-//                                                        ^ reference local 14
+//                                                        ^ reference local 19
 }
 
 export function genericArrow2(): Foobar[] {
@@ -81,8 +81,8 @@ export function genericArrow2(): Foobar[] {
   // because `map`  is missing an explicit `map<Foobar>` annotation.
   return [1].map(n => ({ foobar: n + 1 }))
 //           ^^^ reference typescript 5.9.3 lib/`lib.es5.d.ts`/Array#map().
-//               ^ definition local 18
+//               ^ definition local 23
 //                       ^^^^^^ reference syntax 1.0.0 src/`object-literals-arrow-function.ts`/foobar0:
-//                               ^ reference local 18
+//                               ^ reference local 23
 }
 

src/FileIndexer.ts

@@ -413,6 +413,25 @@ export class FileIndexer {
   }
 
   private getParent(node: ts.Node): ts.Node {
+    if (ts.isPropertyAccessExpression(node.parent)) {
+      if (node === node.parent.name) {
+        return node.parent.expression
+      }
+
+      return this.getParent(node.parent)
+    }
+
+    if (
+      ts.isBinaryExpression(node.parent) &&
+      node.parent.operatorToken.kind === ts.SyntaxKind.FirstAssignment
+    ) {
+      if (node === node.parent.right) {
+        return node.parent.left
+      }
+
+      return this.getParent(node.parent)
+    }
+
     if (isAnonymousContainerOfSymbols(node.parent)) {
       return this.getParent(node.parent)
     }
@@ -496,6 +515,16 @@ export class FileIndexer {
       }
     }
 
+    if (ts.isPropertyAccessExpression(node)) {
+      node = node.name
+    }
+    if (
+      ts.isBinaryExpression(node) &&
+      node.operatorToken.kind === ts.SyntaxKind.FirstAssignment
+    ) {
+      node = node.right
+    }
+
     const ownerNode = this.getParent(node)
     const owner = this.scipSymbol(ownerNode)
     if (owner.isEmpty() || owner.isLocal()) {
@@ -584,6 +613,9 @@ export class FileIndexer {
     if (ts.isTypeLiteralNode(node)) {
       return metaDescriptor('typeLiteral' + this.localCounter.next().toString())
     }
+    if (ts.isIdentifier(node)) {
+      return termDescriptor(node.getText())
+    }
     return undefined
   }