Skip to content

Commit 3bd3cfb

Browse files
committed
fix(backport): adapt src auth token for release/7.0.1
1 parent 9f2a6fa commit 3bd3cfb

File tree

3 files changed

+34
-33
lines changed

3 files changed

+34
-33
lines changed

cmd/src/auth_token.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,11 +50,11 @@ func init() {
5050
}
5151

5252
func resolveAuthToken(ctx context.Context, cfg *config) (string, error) {
53-
if cfg.accessToken != "" {
54-
return cfg.accessToken, nil
53+
if cfg.AccessToken != "" {
54+
return cfg.AccessToken, nil
5555
}
5656

57-
oauthToken, err := loadOAuthToken(ctx, cfg.endpointURL)
57+
oauthToken, err := loadOAuthToken(ctx, cfg.Endpoint)
5858
if err != nil {
5959
return "", errors.Wrap(err, "error loading OAuth token; set SRC_ACCESS_TOKEN or run `src login`")
6060
}

cmd/src/auth_token_test.go

Lines changed: 29 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ package main
33
import (
44
"context"
55
"fmt"
6-
"net/url"
76
"testing"
87

98
"github.com/sourcegraph/src-cli/internal/oauth"
@@ -18,12 +17,12 @@ func TestResolveAuthToken(t *testing.T) {
1817
newOAuthTokenRefresher = func(*oauth.Token) oauthTokenRefresher {
1918
newRefresherCalled = true
2019
return fakeOAuthTokenRefresher{}
21-
}
20+
}
2221

23-
token, err := resolveAuthToken(context.Background(), &config{
24-
accessToken: "access-token",
25-
endpointURL: mustParseURL(t, "https://example.com"),
26-
})
22+
token, err := resolveAuthToken(context.Background(), &config{
23+
AccessToken: "access-token",
24+
Endpoint: "https://example.com",
25+
})
2726
if err != nil {
2827
t.Fatal(err)
2928
}
@@ -39,19 +38,19 @@ func TestResolveAuthToken(t *testing.T) {
3938
reset := stubAuthTokenDependencies(t)
4039
defer reset()
4140

42-
loadOAuthToken = func(context.Context, *url.URL) (*oauth.Token, error) {
43-
return &oauth.Token{
44-
AccessToken: "oauth-token",
45-
}, nil
41+
loadOAuthToken = func(context.Context, string) (*oauth.Token, error) {
42+
return &oauth.Token{
43+
AccessToken: "oauth-token",
44+
}, nil
4645
}
4746

4847
newOAuthTokenRefresher = func(*oauth.Token) oauthTokenRefresher {
4948
return fakeOAuthTokenRefresher{token: oauth.Token{AccessToken: "oauth-token"}}
50-
}
49+
}
5150

52-
token, err := resolveAuthToken(context.Background(), &config{
53-
endpointURL: mustParseURL(t, "https://example.com"),
54-
})
51+
token, err := resolveAuthToken(context.Background(), &config{
52+
Endpoint: "https://example.com",
53+
})
5554
if err != nil {
5655
t.Fatal(err)
5756
}
@@ -64,17 +63,17 @@ func TestResolveAuthToken(t *testing.T) {
6463
reset := stubAuthTokenDependencies(t)
6564
defer reset()
6665

67-
loadOAuthToken = func(context.Context, *url.URL) (*oauth.Token, error) {
68-
return &oauth.Token{AccessToken: "old-token"}, nil
69-
}
66+
loadOAuthToken = func(context.Context, string) (*oauth.Token, error) {
67+
return &oauth.Token{AccessToken: "old-token"}, nil
68+
}
7069

7170
newOAuthTokenRefresher = func(*oauth.Token) oauthTokenRefresher {
7271
return fakeOAuthTokenRefresher{token: oauth.Token{AccessToken: "new-token"}}
73-
}
72+
}
7473

75-
token, err := resolveAuthToken(context.Background(), &config{
76-
endpointURL: mustParseURL(t, "https://example.com"),
77-
})
74+
token, err := resolveAuthToken(context.Background(), &config{
75+
Endpoint: "https://example.com",
76+
})
7877
if err != nil {
7978
t.Fatal(err)
8079
}
@@ -87,20 +86,20 @@ func TestResolveAuthToken(t *testing.T) {
8786
reset := stubAuthTokenDependencies(t)
8887
defer reset()
8988

90-
loadOAuthToken = func(context.Context, *url.URL) (*oauth.Token, error) {
91-
return &oauth.Token{AccessToken: "old-token"}, nil
92-
}
89+
loadOAuthToken = func(context.Context, string) (*oauth.Token, error) {
90+
return &oauth.Token{AccessToken: "old-token"}, nil
91+
}
9392
newOAuthTokenRefresher = func(*oauth.Token) oauthTokenRefresher {
9493
return fakeOAuthTokenRefresher{err: fmt.Errorf("refresh failed")}
9594
}
9695

97-
_, err := resolveAuthToken(context.Background(), &config{
98-
endpointURL: mustParseURL(t, "https://example.com"),
96+
_, err := resolveAuthToken(context.Background(), &config{
97+
Endpoint: "https://example.com",
98+
})
99+
if err == nil {
100+
t.Fatal("expected error")
101+
}
99102
})
100-
if err == nil {
101-
t.Fatal("expected error")
102-
}
103-
})
104103
}
105104

106105
func stubAuthTokenDependencies(t *testing.T) func() {

internal/oauth/http_transport.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ import (
55
"net/http"
66
"sync"
77
"time"
8+
9+
"github.com/sourcegraph/sourcegraph/lib/errors"
810
)
911

1012
var _ http.Transport

0 commit comments

Comments
 (0)