Add noopPending to not render pending updates in no TTY-like environments

Pending defaulted to PendingSimple when we detected that we are in a
non-TTY environment but the output is quite noisy and is more suited for
verbose output.

We add `noopPending` which is used when:
- not in a TTY environment
- not in verbose mode

While testing, I noticed that the `-v` flag does not activate verbose
mode, which is something that we should fix when this command is
migrated to urfave/cli

Author: burmudar

cmd/src/doc.go

@@ -42,6 +42,7 @@ Examples:
 			return err
 		}
 
+		// TODO(burmudar): verbose flag doesn't work here. When this command is migrated we need to wire it up properly
 		out := output.NewOutput(flagSet.Output(), output.OutputOpts{Verbose: *verbose})
 		if *outputFlag == "" {
 			out.WriteLine(output.Line(output.EmojiFailure, output.StyleWarning, "output directory must be set via -o"))

lib/output/pending.go

@@ -18,9 +18,12 @@ type Pending interface {
 }
 
 func newPending(message FancyLine, o *Output) Pending {
-	if !o.caps.Isatty {
+	if o.caps.Isatty {
+		return newPendingTTY(message, o)
+	}
+	if o.verbose {
 		return newPendingSimple(message, o)
 	}
 
-	return newPendingTTY(message, o)
+	return &noopPending{}
 }

lib/output/pending_noop.go

@@ -0,0 +1,17 @@
+package output
+
+type noopPending struct{}
+
+var _ Pending = &noopPending{}
+
+func (n *noopPending) Close()                              {}
+func (n *noopPending) Complete(message FancyLine)          {}
+func (n *noopPending) Destroy()                            {}
+func (n *noopPending) Update(s string)                     {}
+func (n *noopPending) Updatef(format string, args ...any)  {}
+func (n *noopPending) Verbose(s string)                    {}
+func (n *noopPending) VerboseLine(line FancyLine)          {}
+func (n *noopPending) Verbosef(format string, args ...any) {}
+func (n *noopPending) Write(s string)                      {}
+func (n *noopPending) WriteLine(line FancyLine)            {}
+func (n *noopPending) Writef(format string, args ...any)   {}