Skip to content

Commit 1846e82

Browse files
committed
PR 2.2 — Extract: Create storage-commons module
Move 3 RuleBasedSegment cache interfaces, 1 in-memory impl, RuleBasedSegmentParser, ParsedRuleBasedSegment, and RuleBasedSegment DTO into new storage-commons module. Depends on parsing-commons and slf4j. Add storage-commons dep to client/pom.xml. AI-Session-Id: fc79892b-4019-43bf-bb4b-1b5865d3533e AI-Tool: claude-code AI-Model: unknown
1 parent c3714c3 commit 1846e82

File tree

10 files changed

+47
-0
lines changed

10 files changed

+47
-0
lines changed

client/pom.xml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -177,6 +177,11 @@
177177
<artifactId>parsing-commons</artifactId>
178178
<version>${project.version}</version>
179179
</dependency>
180+
<dependency>
181+
<groupId>io.split.client</groupId>
182+
<artifactId>storage-commons</artifactId>
183+
<version>${project.version}</version>
184+
</dependency>
180185
<dependency>
181186
<groupId>io.split.client</groupId>
182187
<artifactId>pluggable-storage</artifactId>

pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,7 @@
6666
<modules>
6767
<module>targeting-engine</module>
6868
<module>parsing-commons</module>
69+
<module>storage-commons</module>
6970
<module>pluggable-storage</module>
7071
<module>redis-wrapper</module>
7172
<module>testing</module>

storage-commons/pom.xml

Lines changed: 41 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
1+
<?xml version="1.0"?>
2+
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
3+
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
4+
<modelVersion>4.0.0</modelVersion>
5+
<parent>
6+
<groupId>io.split.client</groupId>
7+
<artifactId>java-client-parent</artifactId>
8+
<version>4.18.3</version>
9+
</parent>
10+
11+
<version>4.18.3</version>
12+
<artifactId>storage-commons</artifactId>
13+
<packaging>jar</packaging>
14+
<name>Storage Commons</name>
15+
<description>RuleBasedSegment cache interfaces, in-memory impl, parser, and domain objects</description>
16+
17+
<dependencies>
18+
<dependency>
19+
<groupId>io.split.client</groupId>
20+
<artifactId>parsing-commons</artifactId>
21+
<version>${project.version}</version>
22+
</dependency>
23+
<dependency>
24+
<groupId>org.slf4j</groupId>
25+
<artifactId>slf4j-api</artifactId>
26+
<version>1.7.36</version>
27+
</dependency>
28+
<dependency>
29+
<groupId>junit</groupId>
30+
<artifactId>junit</artifactId>
31+
<version>4.13.1</version>
32+
<scope>test</scope>
33+
</dependency>
34+
<dependency>
35+
<groupId>org.mockito</groupId>
36+
<artifactId>mockito-core</artifactId>
37+
<version>5.14.2</version>
38+
<scope>test</scope>
39+
</dependency>
40+
</dependencies>
41+
</project>

client/src/main/java/io/split/client/dtos/RuleBasedSegment.java renamed to storage-commons/src/main/java/io/split/client/dtos/RuleBasedSegment.java

File renamed without changes.

client/src/main/java/io/split/engine/experiments/ParsedRuleBasedSegment.java renamed to storage-commons/src/main/java/io/split/engine/experiments/ParsedRuleBasedSegment.java

File renamed without changes.

client/src/main/java/io/split/engine/experiments/RuleBasedSegmentParser.java renamed to storage-commons/src/main/java/io/split/engine/experiments/RuleBasedSegmentParser.java

File renamed without changes.

client/src/main/java/io/split/storages/RuleBasedSegmentCache.java renamed to storage-commons/src/main/java/io/split/storages/RuleBasedSegmentCache.java

File renamed without changes.

client/src/main/java/io/split/storages/RuleBasedSegmentCacheConsumer.java renamed to storage-commons/src/main/java/io/split/storages/RuleBasedSegmentCacheConsumer.java

File renamed without changes.

client/src/main/java/io/split/storages/RuleBasedSegmentCacheProducer.java renamed to storage-commons/src/main/java/io/split/storages/RuleBasedSegmentCacheProducer.java

File renamed without changes.

client/src/main/java/io/split/storages/memory/RuleBasedSegmentCacheInMemoryImp.java renamed to storage-commons/src/main/java/io/split/storages/memory/RuleBasedSegmentCacheInMemoryImp.java

File renamed without changes.

0 commit comments

Comments
 (0)