refactor: strip metadata from TargetingRule and EvaluationResult

TargetingRule now holds only evaluation fields (seed, killed, defaultTreatment,
conditions, trafficAllocation, trafficAllocationSeed, algo, prerequisites).
Metadata (name, changeNumber, trafficTypeName, configurations, flagSets,
impressionsDisabled) lives exclusively in ParsedSplit.

EvaluationResult carries only (treatment, label). EvaluatorImp.getTreatment()
enriches changeNumber, config, and impressionsDisabled from ParsedSplit after
the engine returns.

VersionedExceptionWrapper no longer carries a version field; the caller uses
parsedSplit.changeNumber() in the catch block instead.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

AI-Session-Id: 724b08af-bcdd-4f98-b354-b4a62fbb2489
AI-Tool: claude-code
AI-Model: unknown

Author: gthea

client/src/main/java/io/split/engine/evaluator/EvaluationContext.java

@@ -38,7 +38,7 @@ public RuleBasedSegmentCacheConsumer getRuleBasedSegmentCache() {
     @Override
     public EvaluationResult evaluate(String matchingKey, String bucketingKey, String ruleName, Map<String, Object> attributes) {
         EvaluatorImp.TreatmentLabelAndChangeNumber r = _evaluator.evaluateFeature(matchingKey, bucketingKey, ruleName, attributes);
-        return new EvaluationResult(r.treatment, r.label, r.changeNumber, r.configurations, r.track);
+        return new EvaluationResult(r.treatment, r.label);
     }
 
     @Override

client/src/main/java/io/split/engine/evaluator/EvaluatorImp.java

@@ -116,9 +116,12 @@ private TreatmentLabelAndChangeNumber getTreatment(String matchingKey, String bu
         try {
             EvaluationResult r = _targetingEngine.evaluate(matchingKey, bucketingKey,
                     parsedSplit.targetingRule(), attributes, _evaluationContext);
-            return new TreatmentLabelAndChangeNumber(r.treatment, r.label, r.version, r.config, r.impressionsDisabled);
+            String config = parsedSplit.configurations() != null
+                    ? parsedSplit.configurations().get(r.treatment) : null;
+            return new TreatmentLabelAndChangeNumber(r.treatment, r.label,
+                    parsedSplit.changeNumber(), config, parsedSplit.impressionsDisabled());
         } catch (VersionedExceptionWrapper e) {
-            throw new ChangeNumberExceptionWrapper(e.wrappedException(), e.version());
+            throw new ChangeNumberExceptionWrapper(e.wrappedException(), parsedSplit.changeNumber());
         }
     }
 

client/src/main/java/io/split/engine/experiments/ParsedSplit.java

@@ -68,8 +68,9 @@ public static ParsedSplit createParsedSplitForTests(
                 flagSets,
                 impressionsDisabled,
                 prerequisitesMatcher,
-                TargetingRuleFactory.buildTargetingRule(feature, seed, killed, defaultTreatment, matcherAndSplits, trafficTypeName,
-                        changeNumber, 100, seed, algo, null, flagSets, impressionsDisabled, prerequisitesMatcher)
+                TargetingRuleFactory.buildTargetingRule(seed, killed, defaultTreatment, matcherAndSplits,
+                        100, seed, algo,
+                        prerequisitesMatcher == null ? Collections.emptyList() : prerequisitesMatcher.getPrerequisites())
         );
     }
 
@@ -102,8 +103,9 @@ public static ParsedSplit createParsedSplitForTests(
                 flagSets,
                 impressionsDisabled,
                 prerequisitesMatcher,
-                TargetingRuleFactory.buildTargetingRule(feature, seed, killed, defaultTreatment, matcherAndSplits, trafficTypeName,
-                        changeNumber, 100, seed, algo, configurations, flagSets, impressionsDisabled, prerequisitesMatcher)
+                TargetingRuleFactory.buildTargetingRule(seed, killed, defaultTreatment, matcherAndSplits,
+                        100, seed, algo,
+                        prerequisitesMatcher == null ? Collections.emptyList() : prerequisitesMatcher.getPrerequisites())
         );
     }
 
@@ -126,9 +128,9 @@ public ParsedSplit(
         this(feature, seed, killed, defaultTreatment, matcherAndSplits, trafficTypeName, changeNumber,
                 trafficAllocation, trafficAllocationSeed, algo, configurations, flagSets,
                 impressionsDisabled, prerequisitesMatcher,
-                TargetingRuleFactory.buildTargetingRule(feature, seed, killed, defaultTreatment, matcherAndSplits, trafficTypeName,
-                        changeNumber, trafficAllocation, trafficAllocationSeed, algo, configurations,
-                        flagSets, impressionsDisabled, prerequisitesMatcher));
+                TargetingRuleFactory.buildTargetingRule(seed, killed, defaultTreatment, matcherAndSplits,
+                        trafficAllocation, trafficAllocationSeed, algo,
+                        prerequisitesMatcher == null ? Collections.emptyList() : prerequisitesMatcher.getPrerequisites()));
     }
 
     public ParsedSplit(

client/src/main/java/io/split/engine/experiments/SplitParser.java

@@ -2,7 +2,6 @@
 
 import java.util.ArrayList;
 import java.util.Collections;
-import java.util.HashSet;
 import java.util.List;
 import java.util.Objects;
 import java.util.stream.Collectors;
@@ -75,19 +74,13 @@ private ParsedSplit parseWithoutExceptionHandling(Split split) {
                         .collect(Collectors.toList());
 
         TargetingRule targetingRule = new TargetingRule(
-                split.name,
                 split.seed,
                 split.killed,
                 split.defaultTreatment,
                 targetingConditionList,
-                split.trafficTypeName,
-                split.changeNumber,
                 split.trafficAllocation,
                 split.trafficAllocationSeed,
                 split.algo,
-                split.configurations,
-                split.sets == null ? new HashSet<>() : split.sets,
-                split.impressionsDisabled,
                 prerequisites);
 
         return new ParsedSplit(

client/src/main/java/io/split/engine/experiments/TargetingRuleFactory.java

@@ -1,16 +1,13 @@
 package io.split.engine.experiments;
 
-import io.split.rules.matchers.PrerequisitesMatcher;
 import io.split.rules.model.Condition;
 import io.split.rules.model.ConditionType;
 import io.split.rules.model.Partition;
 import io.split.rules.model.Prerequisite;
 import io.split.rules.model.TargetingRule;
 
 import java.util.Collections;
-import java.util.HashSet;
 import java.util.List;
-import java.util.Map;
 import java.util.stream.Collectors;
 
 public final class TargetingRuleFactory {
@@ -20,27 +17,19 @@ private TargetingRuleFactory() {
     }
 
     public static TargetingRule buildTargetingRule(
-            String feature, int seed, boolean killed, String defaultTreatment,
-            List<ParsedCondition> matcherAndSplits, String trafficTypeName, long changeNumber,
+            int seed, boolean killed, String defaultTreatment,
+            List<ParsedCondition> matcherAndSplits,
             int trafficAllocation, int trafficAllocationSeed, int algo,
-            Map<String, String> configurations, HashSet<String> flagSets,
-            boolean impressionsDisabled, PrerequisitesMatcher prerequisitesMatcher) {
+            List<Prerequisite> prerequisites) {
 
         List<Condition> conditions = matcherAndSplits == null
                 ? Collections.emptyList()
                 : matcherAndSplits.stream()
                         .map(TargetingRuleFactory::toTargetingCondition)
                         .collect(Collectors.toList());
 
-        List<Prerequisite> prereqs = prerequisitesMatcher == null
-                ? Collections.emptyList()
-                : prerequisitesMatcher.getPrerequisites() == null
-                        ? Collections.emptyList()
-                        : Collections.unmodifiableList(prerequisitesMatcher.getPrerequisites());
-
-        return new TargetingRule(feature, seed, killed, defaultTreatment, conditions, trafficTypeName,
-                changeNumber, trafficAllocation, trafficAllocationSeed, algo, configurations,
-                flagSets == null ? new HashSet<>() : flagSets, impressionsDisabled, prereqs);
+        return new TargetingRule(seed, killed, defaultTreatment, conditions,
+                trafficAllocation, trafficAllocationSeed, algo, prerequisites);
     }
 
     private static Condition toTargetingCondition(ParsedCondition c) {