Meson support by ringlej · Pull Request #666 · stephane/libmodbus

ringlej · 2022-11-08T14:58:07Z

This adds support to build using meson build
Porting over all of the autotools to meson including unit tests

cla-bot · 2022-11-08T14:58:09Z

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient...

cla-bot · 2022-11-08T15:04:10Z

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient...

cla-bot · 2022-11-08T15:15:28Z

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient...

cla-bot · 2022-11-08T15:47:22Z

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient...

cla-bot · 2022-11-08T15:52:48Z

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient...

cla-bot · 2022-11-08T15:54:47Z

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient...

cla-bot · 2022-11-08T16:01:22Z

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient...

cla-bot · 2022-11-08T16:04:35Z

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient...

ringlej · 2022-11-08T16:06:43Z

I added .github/workflows/meson-build.yml to build and test via meson

cla-bot · 2022-11-08T16:34:42Z

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient...

cla-bot · 2022-11-08T17:40:56Z

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient...

cla-bot · 2022-11-08T17:51:12Z

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient...

eli-schwartz · 2022-11-09T04:32:18Z

+lt_current = 6
+lt_revision = 0
+lt_age = 1
+lt_version = '@0@.@1@.@2@'.format(lt_current, lt_age, lt_revision)


libtool version actually maps a bit funky to regular versions, the math for it is (C - A).(A).(R).

Interesting. I changed it to:

lt_current = 6 lt_revision = 0 lt_age = 1 lt_version = '@0@.@1@.@2@'.format(lt_current - lt_age, lt_age, lt_revision)

and I get the following files created:

lrwxrwxrwx 1 jringle domain users 14 Nov 8 23:58 libmodbus.so -> libmodbus.so.6* -rwxr-xr-x 1 jringle domain users 121176 Nov 8 23:58 libmodbus.so.5.1.0* lrwxrwxrwx 1 jringle domain users 18 Nov 8 23:58 libmodbus.so.6 -> libmodbus.so.5.1.0*

Is this correct?

Well, you need one more small tweak I just mentioned below.

eli-schwartz · 2022-11-09T05:03:31Z

+                           version: lt_version,
+                           soversion: lt_current,


If you drop the soversion definition, Meson will default to using the first component of the version, which is usually what people want (and is compatible with autotools).

I feel like I'm missing understanding something... What's the point of doing (C - A).(A).(R) if (C) never gets used on its own? Why not just make C=5 and just do (C).(A).(R)?

cla-bot · 2022-11-09T05:41:07Z

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient...

cla-bot · 2022-11-09T05:49:07Z

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient...

cla-bot · 2022-11-09T06:03:16Z

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient...

cla-bot · 2022-11-09T06:06:09Z

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient...

cla-bot · 2022-11-09T06:57:58Z

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient...

cla-bot · 2022-11-09T07:00:42Z

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient...

yegorich · 2024-03-28T07:35:08Z

@stephane what is the status of this PR? What is still missing?

@ringlej could you rebase this PR on top of master?

ringlej · 2024-03-28T10:52:36Z

Why is a rebase needed?
The PR consists entirely of new files

yegorich · 2024-03-28T14:22:29Z

This way other users can build the current code without git cherry-picking.

yegorich · 2024-04-01T09:37:52Z

Thanks for rebasing. I tested this PR with both meson 0.61.2 and also meson's git master branch. Everything is working as expected and I saw no meson warnings.

As meson support can be provided alongside the autoconf, can we merge it and note that this is a new experimental build system?

stephane · 2024-07-17T13:03:00Z

@yegorich I think it's a good approach.

yegorich · 2024-07-17T14:43:58Z

@stephane great. Then, let's move this PR forward.

yegorich · 2025-05-28T07:31:50Z

@stephane gentle ping :-)

ringlej force-pushed the meson-support branch from d88341d to e429b4c Compare November 8, 2022 15:15

ringlej force-pushed the meson-support branch from 96edf26 to 60a5bc5 Compare November 8, 2022 15:52

ringlej force-pushed the meson-support branch from 60a5bc5 to 43ebaa7 Compare November 8, 2022 15:54

ringlej force-pushed the meson-support branch from 43ebaa7 to 887dc3e Compare November 8, 2022 16:01

ringlej force-pushed the meson-support branch from 887dc3e to b59e538 Compare November 8, 2022 16:04

ringlej force-pushed the meson-support branch from ae11522 to 40b13a0 Compare November 8, 2022 17:40

ringlej force-pushed the meson-support branch from 40b13a0 to 5dfa3ae Compare November 8, 2022 17:51

eli-schwartz suggested changes Nov 9, 2022

View reviewed changes

ringlej force-pushed the meson-support branch from 5dfa3ae to 52b8aaa Compare November 9, 2022 05:41

ringlej force-pushed the meson-support branch from 52b8aaa to bcec07c Compare November 9, 2022 05:49

ringlej force-pushed the meson-support branch from 5ee6474 to d8f505c Compare November 9, 2022 06:06

ringlej mentioned this pull request Nov 9, 2022

Meson support gridpoint-com/libmodbus#4

Merged

ringlej force-pushed the meson-support branch from be7174f to d8f505c Compare November 9, 2022 07:00

stephane self-assigned this Nov 28, 2022

stephane added the cla-signed label Nov 28, 2022

ringlej added 2 commits March 28, 2024 10:37

meson build: Add support for meson build

2815dd7

Add .github/workflows/meson-build.yml

d991c25

ringlej force-pushed the meson-support branch from d8f505c to d991c25 Compare March 28, 2024 14:37

Uh oh!

Conversation

ringlej commented Nov 8, 2022

Uh oh!

cla-bot Bot commented Nov 8, 2022

Uh oh!

cla-bot Bot commented Nov 8, 2022

Uh oh!

cla-bot Bot commented Nov 8, 2022

Uh oh!

cla-bot Bot commented Nov 8, 2022

Uh oh!

cla-bot Bot commented Nov 8, 2022

Uh oh!

cla-bot Bot commented Nov 8, 2022

Uh oh!

cla-bot Bot commented Nov 8, 2022

Uh oh!

cla-bot Bot commented Nov 8, 2022

Uh oh!

ringlej commented Nov 8, 2022

Uh oh!

cla-bot Bot commented Nov 8, 2022

Uh oh!

cla-bot Bot commented Nov 8, 2022

Uh oh!

cla-bot Bot commented Nov 8, 2022

Uh oh!

Uh oh!

eli-schwartz Nov 9, 2022

Choose a reason for hiding this comment

Uh oh!

ringlej Nov 9, 2022

Choose a reason for hiding this comment

Uh oh!

eli-schwartz Nov 9, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

eli-schwartz Nov 9, 2022

Choose a reason for hiding this comment

Uh oh!

ringlej Nov 9, 2022

Choose a reason for hiding this comment

Uh oh!

cla-bot Bot commented Nov 9, 2022

Uh oh!

cla-bot Bot commented Nov 9, 2022

Uh oh!

cla-bot Bot commented Nov 9, 2022

Uh oh!

cla-bot Bot commented Nov 9, 2022

Uh oh!

cla-bot Bot commented Nov 9, 2022

Uh oh!

cla-bot Bot commented Nov 9, 2022

Uh oh!

yegorich commented Mar 28, 2024

Uh oh!

ringlej commented Mar 28, 2024

Uh oh!

yegorich commented Mar 28, 2024

Uh oh!

yegorich commented Apr 1, 2024

Uh oh!

stephane commented Jul 17, 2024

Uh oh!

yegorich commented Jul 17, 2024

Uh oh!

yegorich commented May 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants