Skip to content
This repository was archived by the owner on Apr 29, 2024. It is now read-only.

Commit dca7f56

Browse files
authored
update internal with typo/phrasing
1 parent ff4e67a commit dca7f56

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

INTERNAL.md

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ nix build .#psql_14/bin -o result-14
1717
nix build .#psql_15/bin -o result-15
1818
```
1919

20-
Builds Postgres 14 & 15 with all of our extensions and symlinks the resulting build artifaces e.g. `psql`, `pg_dump` etc at `result-14` and `result-15` respectively.
20+
Builds Postgres 14 & 15 with all of our extensions and symlinks the resulting build artifacts e.g. `psql`, `pg_dump` etc at `result-14` and `result-15` respectively.
2121

2222

2323
On first run these commands will take a long time to complete. Intermediate results are cached and reused leading to significantly reduced built times on subsequent runs.
@@ -153,9 +153,9 @@ Once available upstream, new versions can be added [here](https://github.com/sup
153153

154154
### A pushed git tag produces an AWS AMI + docker image.
155155

156-
Not in prototype functional
156+
Not in prototype
157157

158-
## Consider that we have the following PostgreSQL targets
158+
## Consider that we have the following PostgreSQL targets:
159159

160160
### Supported PostgreSQL versions (14), these are older versions not yet migrated to latest
161161

@@ -179,17 +179,18 @@ Support pending upstream merge of [PR](https://github.com/NixOS/nixpkgs/pull/249
179179

180180
### Future patch PostgreSQL version (14.x, 15.y)
181181

182-
These occur upstream. If we want to stay on the outdated version we can add an overlay to this repo.
182+
These occur upstream. If we want to stay on the outdated version we can add an override to this repo.
183183

184184
### Each version will be tested against all extensions
185185

186186
Builtin and runs in CI
187187

188188
## Limitations
189189

190-
### Lack of darwin-arm support
190+
- Lack of darwin-arm support: This is blocked by pgrx extensions. Everything except those extensions is functional.
191+
- Difficulty producing docker images in Github Actions CI: solvable with changes to our custom runners
192+
191193

192-
This is blocked by pgrx extensions. Everything except those extensions is functional.
193194

194195
## Other
195196

0 commit comments

Comments
 (0)