Commit 0c9f3b1
committed
Allow extra refs to be marked as optional in run-task
Also mark the notes/decision-parameters one as optional in this repo.
This prevents failures if a fork doesn't have any notes at
`refs/notes/decision-parameters`. I chose to pay for the `ls-remote`
time if an optional ref failed to fetch to avoid having to parse the
stderr from git fetch which felt very fragile. It adds a potential ~1.5s
to fetches per optional remote that is missing which isn't ideal, but I
don't have anything better at this point in time. The new log message is
slightly misleading since technically ls-remote might find one ref but
not another and it'd be reported that both are missing but I don't want
to have to ls-remote for each ref, adding 1.5s each time, to fix this.1 parent fa30e4b commit 0c9f3b1
2 files changed
+32
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
226 | 226 | | |
227 | 227 | | |
228 | 228 | | |
229 | | - | |
| 229 | + | |
230 | 230 | | |
231 | 231 | | |
232 | 232 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
574 | 574 | | |
575 | 575 | | |
576 | 576 | | |
| 577 | + | |
577 | 578 | | |
578 | 579 | | |
579 | 580 | | |
| |||
584 | 585 | | |
585 | 586 | | |
586 | 587 | | |
| 588 | + | |
| 589 | + | |
| 590 | + | |
| 591 | + | |
| 592 | + | |
| 593 | + | |
| 594 | + | |
| 595 | + | |
| 596 | + | |
| 597 | + | |
| 598 | + | |
| 599 | + | |
| 600 | + | |
| 601 | + | |
| 602 | + | |
| 603 | + | |
| 604 | + | |
| 605 | + | |
| 606 | + | |
| 607 | + | |
| 608 | + | |
| 609 | + | |
| 610 | + | |
| 611 | + | |
587 | 612 | | |
588 | 613 | | |
589 | 614 | | |
| |||
735 | 760 | | |
736 | 761 | | |
737 | 762 | | |
738 | | - | |
| 763 | + | |
| 764 | + | |
| 765 | + | |
| 766 | + | |
739 | 767 | | |
740 | 768 | | |
741 | | - | |
| 769 | + | |
742 | 770 | | |
| 771 | + | |
743 | 772 | | |
744 | 773 | | |
745 | 774 | | |
| |||
0 commit comments