View attribute binding drops numeric zero values

[sander-bol]

Tempest version

3.11.6

PHP version

8.5

Operating system

macOS

Description

Tempest view attribute bindings appear to omit an attribute when the bound value is numeric 0 or float 0.0. This is surprising for non-boolean attributes such as data-*, where "0" is a meaningful value.

We hit this while rendering a proportional conference schedule. A talk starting exactly at the beginning of the timeline had start_percent = 0.0, which we render as:

<article
    data-talk-lineup-talk
    :data-start-percent="$lineupTalk['start_percent']"
    :data-width-percent="$lineupTalk['width_percent']"
>

Expected output:

<article data-talk-lineup-talk data-start-percent="0" data-width-percent="10">

Actual output:

<article data-talk-lineup-talk data-width-percent="10">

This is (to me, at least) unexpected behavior. It looks like the intent was to drop :empty-attribute="" - which is a defensible choice given HTML's semantics, but it's a bit too wide. On a data-level, the value '0' is semantically relevant - it shouldn't be a view layer's decision to completely omit the attribute in this case. I expect this to be a bug due to a non-strict !empty()-check.

[sander-bol]

Minimal reproduction case, in case it helps:

<?php
require_once('vendor/autoload.php');

use Tempest\Core\Tempest;
use function Tempest\View\view;

$container = Tempest::boot();
echo $container
	->get(\Tempest\View\ViewRenderer::class)
	->render(view('<div :data-x="$value" :aria-valuenow="$value" :title="$value" id="repro" data-y="0" />', value: 0));

// Actual: <div id="repro" data-y="0"   ></div>
// Expected: <div data-x="0" aria-valuenow="0" title="0" id="repro" data-y="0"></div>

[sander-bol]

Thanks for trying to tackle my issue, @sawirricardo - appreciate it! :)