From 320276bfa0cbd0d24e33be5f54ca582cbadffcb7 Mon Sep 17 00:00:00 2001 From: Leon Yang Date: Mon, 1 Jun 2026 16:13:39 +0800 Subject: [PATCH 1/2] Skip TestS3Arn in all tests run --- .github/workflows/import-scene-test-dev.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/import-scene-test-dev.yml b/.github/workflows/import-scene-test-dev.yml index fceefb4..fe96166 100644 --- a/.github/workflows/import-scene-test-dev.yml +++ b/.github/workflows/import-scene-test-dev.yml @@ -32,7 +32,7 @@ jobs: run: | if [ -z ${{ github.event.inputs.testCase }} ]; then echo "Running all tests" - go run gotest.tools/gotestsum@latest --format standard-verbose -- sceneTest/import/* -timeout 30m -args --cid 10987985172501194742 --config "${{ secrets.TEST_CONFIG_DEV }}" --test.timeout 30m + go run gotest.tools/gotestsum@latest --format standard-verbose -- sceneTest/import/* -timeout 30m -args --cid 10987985172501194742 --config "${{ secrets.TEST_CONFIG_DEV }}" --test.timeout 30m --test.skip "TestS3Arn" else echo "Running test ${{ github.event.inputs.testCase }}" go run gotest.tools/gotestsum@latest --format standard-verbose -- sceneTest/import/* -args --cid 10987985172501194742 --config "${{ secrets.TEST_CONFIG_DEV }}" --test.run ${{ github.event.inputs.testCase }} From 73094e9796a7fa180f39bb1d08deec748561dfea Mon Sep 17 00:00:00 2001 From: Leon Yang Date: Mon, 1 Jun 2026 16:14:51 +0800 Subject: [PATCH 2/2] Uncomment TestZeroDateImport function implementation --- sceneTest/import/import_test.go | 72 ++++++++++++++++----------------- 1 file changed, 36 insertions(+), 36 deletions(-) diff --git a/sceneTest/import/import_test.go b/sceneTest/import/import_test.go index cacfc19..546a640 100644 --- a/sceneTest/import/import_test.go +++ b/sceneTest/import/import_test.go @@ -180,39 +180,39 @@ func TestSchemaColumnNumberMismatchedImport(t *testing.T) { } // TestZeroDateImport verifies zero date strings can be imported without errors -// func TestZeroDateImport(t *testing.T) { -// ctx := context.Background() - -// if _, err := db.ExecContext(ctx, "DROP TABLE IF EXISTS `test`.`zero_date`"); err != nil { -// t.Fatalf("Failed to drop zero date import table: %v", err) -// } - -// cfg := config.LoadConfig() - -// importOptions := imp.ImportOptions{ -// FileType: imp.IMPORTFILETYPEENUM_CSV, -// CsvFormat: &imp.CSVFormat{ -// Separator: pointer.ToString(";"), -// }, -// } - -// s3Source := &imp.S3Source{ -// Uri: cfg.Import.S3.ZeroDateURI, -// AuthType: imp.IMPORTS3AUTHTYPEENUM_ACCESS_KEY, -// AccessKey: &imp.S3SourceAccessKey{ -// Id: cfg.S3.AccessKeyID, -// Secret: cfg.S3.SecretAccessKey, -// }, -// } - -// importID, err := createS3Import(ctx, importOptions, s3Source) -// if err != nil { -// t.Fatalf("Failed to create zero date import: %v", err) -// } - -// if err := waitImport(ctx, importID); err != nil { -// t.Fatalf("Zero date import failed, importId: %s, error: %v", importID, err) -// } - -// t.Log("Zero date import completed successfully") -// } +func TestZeroDateImport(t *testing.T) { + ctx := context.Background() + + if _, err := db.ExecContext(ctx, "DROP TABLE IF EXISTS `test`.`zero_date`"); err != nil { + t.Fatalf("Failed to drop zero date import table: %v", err) + } + + cfg := config.LoadConfig() + + importOptions := imp.ImportOptions{ + FileType: imp.IMPORTFILETYPEENUM_CSV, + CsvFormat: &imp.CSVFormat{ + Separator: pointer.ToString(";"), + }, + } + + s3Source := &imp.S3Source{ + Uri: cfg.Import.S3.ZeroDateURI, + AuthType: imp.IMPORTS3AUTHTYPEENUM_ACCESS_KEY, + AccessKey: &imp.S3SourceAccessKey{ + Id: cfg.S3.AccessKeyID, + Secret: cfg.S3.SecretAccessKey, + }, + } + + importID, err := createS3Import(ctx, importOptions, s3Source) + if err != nil { + t.Fatalf("Failed to create zero date import: %v", err) + } + + if err := waitImport(ctx, importID); err != nil { + t.Fatalf("Zero date import failed, importId: %s, error: %v", importID, err) + } + + t.Log("Zero date import completed successfully") +}