Merge pull request #1580 from topcoder-platform/PM-4636

PM-4636: make task reviewer optional

Author: jmgasper

src/apps/work/src/lib/schemas/challenge-editor.schema.spec.ts

@@ -35,7 +35,7 @@ describe('challenge-editor schema task reviewer validation', () => {
         roundType: ROUND_TYPES.SINGLE_ROUND,
     }
 
-    it('requires reviewer for task internal review', async () => {
+    it('does not require reviewer for task internal review', async () => {
         await expect(
             challengeAdvancedOptionsSchema.validate({
                 ...baseFormData,
@@ -46,8 +46,8 @@ describe('challenge-editor schema task reviewer validation', () => {
                 reviewer: '',
             }),
         )
-            .rejects
-            .toThrow('Select a reviewer')
+            .resolves
+            .toBeTruthy()
     })
 
     it('does not require reviewer for non-task internal review', async () => {

src/apps/work/src/lib/schemas/challenge-editor.schema.ts

@@ -459,22 +459,7 @@ export const challengeAdvancedOptionsSchema = yup.object({
         .optional(),
     reviewer: yup.string()
         .transform(emptyStringToUndefined)
-        .when([
-            'legacy.isTask',
-            'legacy.reviewType',
-        ], {
-            is: (
-                isTask: boolean | undefined,
-                reviewType: string | undefined,
-            ): boolean => (
-                isTask === true
-                && String(reviewType || '')
-                    .trim()
-                    .toUpperCase() === REVIEW_TYPES.INTERNAL
-            ),
-            otherwise: schema => schema.optional(),
-            then: schema => schema.required('Select a reviewer'),
-        }),
+        .optional(),
     reviewers: yup.array()
         .of(reviewerSchema)
         .optional(),

src/apps/work/src/pages/challenges/ChallengeEditorPage/README.md

@@ -30,7 +30,7 @@ The form uses `challengeBasicInfoSchema` from `src/apps/work/src/lib/schemas/cha
 - `wiproAllowed`: optional boolean, defaults to `false` (unchecked).
 - `tags`: optional string array.
 - `skills`: required unless billing account is listed in `SKILLS_OPTIONAL_BILLING_ACCOUNT_IDS`.
-- `reviewer`: required for task challenges when `legacy.reviewType` is `INTERNAL`.
+- `reviewer`: optional for task challenges.
 - `reviewers`: when using `Save as Draft` from `NEW` status, non-task/non-marathon challenges must include reviewer coverage for configured review phases. If required phases are configured, each phase must have at least one member reviewer with a scorecard.
 - `AI review configuration`: templates and manual configs autosave separately once valid, and the AI tab becomes read-only after the challenge has submissions.
 

src/apps/work/src/pages/challenges/ChallengeEditorPage/components/ReviewTypeField/ReviewTypeField.spec.tsx

@@ -103,7 +103,7 @@ describe('ReviewTypeField', () => {
             screen.getByTestId('reviewer-autocomplete')
                 .getAttribute('data-required'),
         )
-            .toBe('true')
+            .toBe('false')
     })
 
     it('forces task challenges to use the internal review type', async () => {

src/apps/work/src/pages/challenges/ChallengeEditorPage/components/ReviewTypeField/ReviewTypeField.tsx

@@ -88,7 +88,6 @@ export const ReviewTypeField: FC<ReviewTypeFieldProps> = (
                 label='Reviewer'
                 name='reviewer'
                 placeholder='Search reviewer'
-                required
             />
         </div>
     )