Merge pull request #1712 from topcoder-platform/PM-4824

PM-4824: honor actual predecessor end dates in schedule editor

Author: jmgasper

src/apps/work/src/pages/challenges/ChallengeEditorPage/README.md

@@ -50,7 +50,7 @@ The form uses `challengeBasicInfoSchema` from `src/apps/work/src/lib/schemas/cha
 - `ChallengeNameField`: text input.
 - `ChallengeTrackField`: track selector from `useFetchChallengeTracks`.
 - `ChallengeTypeField`: active type selector from `useFetchChallengeTypes`, excluding `Topgear Task` because that flow is not launchable from the work app editor. When the selected track is Design or QA, it also hides `Marathon Match` to match the legacy work-manager create flow and clears any now-invalid preselection.
-- `ChallengeScheduleSection`: schedule editor for challenge start and phase dates. It keeps the detected timezone above the controls, renders the `Start Date` label with the `Scheduled` and `Immediately` start-mode radios aligned to the end of that header row above the input with a green selected state, persists the selected start mode in challenge metadata so saved `/edit` and `/view` routes reopen with the correct radio state, recalculates root phase dates when the challenge start changes, and keeps completed phases' end-date and duration controls locked to match legacy work-manager behavior. `Task` challenges hide this editable section across create, edit, and read-only view routes to match legacy work-manager behavior.
+- `ChallengeScheduleSection`: schedule editor for challenge start and phase dates. It keeps the detected timezone above the controls, renders the `Start Date` label with the `Scheduled` and `Immediately` start-mode radios aligned to the end of that header row above the input with a green selected state, persists the selected start mode in challenge metadata so saved `/edit` and `/view` routes reopen with the correct radio state, recalculates root phase dates when the challenge start changes, honors a completed predecessor phase's actual end date when deriving successor schedule rows, and keeps completed phases' end-date and duration controls locked to match legacy work-manager behavior. `Task` challenges hide this editable section across create, edit, and read-only view routes to match legacy work-manager behavior.
 - `DesignWorkTypeField`: shown for Design + Challenge, with the legacy work-type options (`Application Front-End Design`, `Print/Presentation`, `Web Design`, `Widget or Mobile Screen Design`, `Wireframes`). The selected value is stored in challenge tags.
 - `FunChallengeField`: shown for `Marathon Match` type and remains editable after creation so the form can switch between fun-challenge and standard marathon-match fields.
 - `ReviewersField`: hidden for `Task` and `Marathon Match` challenges because manual reviewer assignment is handled elsewhere. On the human-review tab, each manual reviewer card keeps the legacy review-type dropdown, backfills missing legacy review-type values from the matching default reviewer or iterative-review phase fallback, and each manual reviewer phase selector hides registration/submission phases and any phase already assigned on another manual reviewer card while preserving the card's current selection.

src/apps/work/src/pages/challenges/ChallengeEditorPage/components/ChallengeScheduleSection/ChallengeScheduleSection.component.spec.tsx

@@ -514,4 +514,50 @@ describe('ChallengeScheduleSection component', () => {
                 isEndDateEditable: true,
             }))
     })
+
+    it('uses a completed predecessor actual end date for the submission row start time', () => {
+        render(
+            <TestHarness
+                phases={[
+                    {
+                        actualEndDate: '2026-04-09T13:14:00.000Z',
+                        duration: 2880,
+                        id: 'phase-1',
+                        isOpen: false,
+                        name: 'Checkpoint Review',
+                        phaseId: 'checkpoint-review-phase',
+                        scheduledEndDate: '2026-04-11T13:02:00.000Z',
+                        scheduledStartDate: '2026-04-09T13:02:00.000Z',
+                    },
+                    {
+                        duration: 19,
+                        id: 'phase-2',
+                        isOpen: true,
+                        name: 'Submission',
+                        phaseId: 'submission-phase',
+                        predecessor: 'checkpoint-review-phase',
+                        scheduledEndDate: '2026-04-09T13:33:00.000Z',
+                        scheduledStartDate: '2026-04-09T13:14:00.000Z',
+                    },
+                ]}
+                startDate='2026-04-09T12:36:00.000Z'
+            />,
+        )
+
+        const renderedPhaseRows = mockPhaseEditorRow.mock.calls
+            .map(([props]) => props as {
+                phase?: {
+                    name?: string
+                }
+                startDate?: string
+            })
+        const submissionRow = [...renderedPhaseRows]
+            .reverse()
+            .find(props => props.phase?.name === 'Submission')
+
+        expect(submissionRow)
+            .toEqual(expect.objectContaining({
+                startDate: '2026-04-09T13:14:00.000Z',
+            }))
+    })
 })

src/apps/work/src/pages/challenges/ChallengeEditorPage/components/ChallengeScheduleSection/ChallengeScheduleSection.spec.ts

@@ -99,6 +99,35 @@ describe('ChallengeScheduleSection helpers', () => {
             expect(result.phases[2]?.scheduledStartDate)
                 .toBe(updatedStartDate)
         })
+
+        it('aligns successor phases to a predecessor actual end date when the predecessor closes early', () => {
+            const checkpointReviewActualEnd = '2026-04-09T13:14:00.000Z'
+            const phases: ChallengePhase[] = [
+                buildPhase({
+                    actualEndDate: checkpointReviewActualEnd,
+                    duration: 48 * 60,
+                    name: 'Checkpoint Review',
+                    phaseId: 'checkpoint-review',
+                    scheduledEndDate: '2026-04-11T13:02:00.000Z',
+                    scheduledStartDate: '2026-04-09T13:02:00.000Z',
+                }),
+                buildPhase({
+                    duration: 19,
+                    name: 'Submission',
+                    phaseId: 'submission',
+                    predecessor: 'checkpoint-review',
+                    scheduledEndDate: '2026-04-09T13:33:00.000Z',
+                    scheduledStartDate: '2026-04-09T13:14:00.000Z',
+                }),
+            ]
+
+            const result = recalculatePhases(phases, '2026-04-09T12:36:00.000Z')
+
+            expect(result.phases[1]?.scheduledStartDate)
+                .toBe(checkpointReviewActualEnd)
+            expect(result.phases[1]?.scheduledEndDate)
+                .toBe('2026-04-09T13:33:00.000Z')
+        })
     })
 
     describe('buildSchedulePhaseRows', () => {

src/apps/work/src/pages/challenges/ChallengeEditorPage/components/ChallengeScheduleSection/ChallengeScheduleSection.utils.ts

@@ -64,6 +64,10 @@ export function normalizePhaseName(value: unknown): string {
         .toLowerCase()
 }
 
+function getPredecessorEndDate(phase?: ChallengePhase): Date | undefined {
+    return toDate(phase?.actualEndDate || phase?.scheduledEndDate)
+}
+
 function isIterativeReviewPhase(phaseName: unknown): boolean {
     return normalizePhaseName(phaseName) === 'iterative review'
 }
@@ -203,7 +207,7 @@ export function recalculatePhases(
         if (phase.predecessor) {
             const predecessorPhase = calculatedByPhaseId.get(phase.predecessor)
             const predecessorStartDate = toDate(predecessorPhase?.scheduledStartDate)
-            const predecessorEndDate = toDate(predecessorPhase?.scheduledEndDate)
+            const predecessorEndDate = getPredecessorEndDate(predecessorPhase)
 
             if (predecessorEndDate) {
                 phaseStartDate = isIterativeReviewPhase(phase.name)