Merge pull request #1643 from topcoder-platform/PM-4710

PM-4710: restore gating workflow guidance

Author: jmgasper

src/apps/work/src/pages/challenges/ChallengeEditorPage/components/ReviewersField/AiReviewTab.module.scss

@@ -200,15 +200,31 @@
     min-height: 42px;
 }
 
+.checkboxRow {
+    align-items: center;
+    display: flex;
+    gap: 8px;
+    min-height: 42px;
+}
+
 .checkboxField input {
     accent-color: #137d60;
 }
 
+.checkboxRow span,
 .checkboxField span {
     color: #3a3f45;
     font-size: 14px;
 }
 
+.checkboxDescription {
+    color: #70757a;
+    display: block;
+    font-size: 12px;
+    line-height: 1.5;
+    margin-top: -2px;
+}
+
 .workflowEditors {
     display: flex;
     flex-direction: column;

src/apps/work/src/pages/challenges/ChallengeEditorPage/components/ReviewersField/AiReviewTab.spec.tsx

@@ -219,4 +219,45 @@ describe('AiReviewTab review mode options', () => {
         expect(screen.queryByRole('heading', { name: 'Workflow1' }))
             .toBeNull()
     })
+
+    it('shows gating workflow helper text for checked and unchecked workflows', async () => {
+        mockedFetchAiReviewConfigByChallenge.mockResolvedValueOnce({
+            ...baseConfiguration,
+            workflows: [
+                {
+                    id: 'draft-1',
+                    isGating: true,
+                    weightPercent: 20,
+                    workflowId: 'workflow-1',
+                },
+                {
+                    id: 'draft-2',
+                    isGating: false,
+                    weightPercent: 80,
+                    workflowId: 'workflow-2',
+                },
+            ],
+        })
+        mockedFetchWorkflows.mockResolvedValueOnce([
+            {
+                id: 'workflow-1',
+                name: 'Workflow 1',
+            },
+            {
+                id: 'workflow-2',
+                name: 'Workflow 2',
+            },
+        ])
+
+        render(
+            <AiReviewTab
+                challengeId='challenge-1'
+                reviewers={persistedAiReviewers}
+            />,
+        )
+
+        expect(await screen.findAllByText(/Submissions below threshold are locked\./))
+            .toHaveLength(2)
+        expect(screen.getByText(/Pass\/fail gate\./)).not.toBeNull()
+    })
 })

src/apps/work/src/pages/challenges/ChallengeEditorPage/components/ReviewersField/AiReviewTab.tsx

@@ -247,6 +247,7 @@ const ManualWorkflowEditor: FC<ManualWorkflowEditorProps> = (
     props: ManualWorkflowEditorProps,
 ) => {
     const workflowId = normalizeReviewerText(props.workflow.workflowId)
+    const gatingDescriptionId = `${props.workflowKey}-gating-description`
     const isAssigned = props.assignedWorkflowIds.has(workflowId)
     const handleWorkflowChange = useCallback(
         (event: ChangeEvent<HTMLSelectElement>): void => {
@@ -319,15 +320,24 @@ const ManualWorkflowEditor: FC<ManualWorkflowEditorProps> = (
                     />
                 </label>
 
-                <label className={styles.checkboxField}>
-                    <input
-                        checked={props.workflow.isGating === true}
-                        disabled={props.readOnly}
-                        onChange={handleGatingChange}
-                        type='checkbox'
-                    />
-                    <span>Use as gating workflow</span>
-                </label>
+                <div className={styles.checkboxField}>
+                    <label className={styles.checkboxRow}>
+                        <input
+                            aria-describedby={gatingDescriptionId}
+                            checked={props.workflow.isGating === true}
+                            disabled={props.readOnly}
+                            onChange={handleGatingChange}
+                            type='checkbox'
+                        />
+                        <span>Use as gating workflow</span>
+                    </label>
+                    <span className={styles.checkboxDescription} id={gatingDescriptionId}>
+                        {props.workflow.isGating
+                            ? 'Pass/fail gate. '
+                            : undefined}
+                        Submissions below threshold are locked.
+                    </span>
+                </div>
             </div>
 
             {workflowId