Skip to content

Commit 74a4ca3

Browse files
fix(webapp): sync custom duration state when period prop changes
Add useEffect to update customValue and customUnit when the period prop changes, fixing stale values in the custom input fields after selecting a preset time period. Co-authored-by: Eric Allam <ericallam@users.noreply.github.com>
1 parent d54909e commit 74a4ca3

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

apps/webapp/app/components/runs/v3/SharedFilters.tsx

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import * as Ariakit from "@ariakit/react";
22
import type { RuntimeEnvironment } from "@trigger.dev/database";
33
import parse from "parse-duration";
44
import type { ReactNode } from "react";
5-
import { startTransition, useCallback, useState } from "react";
5+
import { startTransition, useCallback, useEffect, useState } from "react";
66
import { AppliedFilter } from "~/components/primitives/AppliedFilter";
77
import { DateField } from "~/components/primitives/DateField";
88
import { DateTime } from "~/components/primitives/DateTime";
@@ -304,6 +304,13 @@ export function TimeDropdown({
304304
const [customValue, setCustomValue] = useState(initialCustom.value);
305305
const [customUnit, setCustomUnit] = useState(initialCustom.unit);
306306

307+
// Sync custom duration state when period prop changes
308+
useEffect(() => {
309+
const parsed = getInitialCustomDuration(period);
310+
setCustomValue(parsed.value);
311+
setCustomUnit(parsed.unit);
312+
}, [period]);
313+
307314
const applyDateRange = useCallback(() => {
308315
replace({
309316
period: undefined,

0 commit comments

Comments
 (0)