NetBSD build failure

[0323pin]

Hi,

After #11176 was merged, I can successfully build coreutils using cargo build.

However building the release tarball with cargo build --no-default-features --features unix fails with:

error[E0255]: the name `ACCOUNTING` is defined multiple times
   --> src/uucore/src/lib/features/utmpx.rs:175:13
    |
167 |     pub const ACCOUNTING: usize = 9;
    |     -------------------------------- previous definition of the value `ACCOUNTING` here
...
175 |     pub use libc::ACCOUNTING;
    |             ^^^^^^^^^^^^^^^^ `ACCOUNTING` reimported here
    |
    = note: `ACCOUNTING` must be defined only once in the value namespace of this module
help: you can use `as` to change the binding name of the import
    |
175 |     pub use libc::ACCOUNTING as OtherACCOUNTING;
    |                              ++++++++++++++++++

warning: unused import: `libc::ACCOUNTING`
   --> src/uucore/src/lib/features/utmpx.rs:175:13
    |
175 |     pub use libc::ACCOUNTING;
    |             ^^^^^^^^^^^^^^^^
    |
    = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default

I saw this was fixed yesterday in de5e4f5
So, I've fetched git-HEAD and once again tried building using cargo build --no-default-features --features unix only to fail with:

error[E0308]: mismatched types
   --> src/uucore/src/lib/features/uptime.rs:159:44
    |
159 |             .filter(|r| r.record_type() == BOOT_TIME)
    |                         ---------------    ^^^^^^^^^ expected `i16`, found `u16`
    |                         |
    |                         expected because this is `i16`
    |
help: you can convert a `u16` to an `i16` and panic if the converted value doesn't fit
    |
159 |             .filter(|r| r.record_type() == BOOT_TIME.try_into().unwrap())
    |                                                     ++++++++++++++++++++

error[E0308]: mismatched types
   --> src/uucore/src/lib/features/uptime.rs:306:32
    |
306 |         if ut.record_type() == USER_PROCESS {
    |            ----------------    ^^^^^^^^^^^^ expected `i16`, found `u16`
    |            |
    |            expected because this is `i16`
    |
help: you can convert a `u16` to an `i16` and panic if the converted value doesn't fit
    |
306 |         if ut.record_type() == USER_PROCESS.try_into().unwrap() {
    |                                            ++++++++++++++++++++

error[E0308]: mismatched types
   --> src/uucore/src/lib/features/utmpx.rs:213:9
    |
212 |     pub fn record_type(&self) -> i16 {
    |                                  --- expected `i16` because of return type
213 |         self.inner.ut_type
    |         ^^^^^^^^^^^^^^^^^^ expected `i16`, found `u16`
    |
help: you can convert a `u16` to an `i16` and panic if the converted value doesn't fit
    |
213 |         self.inner.ut_type.try_into().unwrap()
    |                           ++++++++++++++++++++

error[E0609]: no field `ut_user` on type `libc::utmpx`
   --> src/uucore/src/lib/features/utmpx.rs:225:34
    |
225 |         chars2string!(self.inner.ut_user)
    |                                  ^^^^^^^ unknown field
    |
    = note: available fields are: `ut_name`, `ut_id`, `ut_line`, `ut_host`, `ut_session` ... and 5 others

error[E0308]: mismatched types
   --> src/uucore/src/lib/features/utmpx.rs:267:58
    |
267 |         !self.user().is_empty() && self.record_type() == USER_PROCESS
    |                                    ------------------    ^^^^^^^^^^^^ expected `i16`, found `u16`
    |                                    |
    |                                    expected because this is `i16`
    |
help: you can convert a `u16` to an `i16` and panic if the converted value doesn't fit
    |
267 |         !self.user().is_empty() && self.record_type() == USER_PROCESS.try_into().unwrap()
    |                                                                      ++++++++++++++++++++

Mind that building with default features works fine, but this causes trouble if building with GNU make because, the OS is detected at build time, Detected OS = NetBSD

This leads to the build using cargo build --features feat_external_libstdbuf --profile=release and the above errors.

I want to build with GNU make because I'm working on a package for NetBSD and would like to install the utils as separated uu- binaries rather than the multibinary.

Any suggestions?
Thanks!

[oech3]

make UTILS=$(sed -n '/feat_Tier1 = \[/,/\]/p' Cargo.toml | sed '1d;2d' |tr -d '],"\n') $(sed -n '/feat_common_core = \[/,/\]/p' Cargo.toml | sed '1d' |tr -d '],"\n') which means you just lost many unix specific utils.

[0323pin]

@oech3 Could you be a bit more specific?

I'm simply guessing now but, you're saying the best would be to build with the unix features?

EDIT: Any thoughts on how you would like to fix the build errors?

[oech3]

build with the unix features?

without.

Any thoughts on how you would like to fix the build errors?

We could replace some libc imports with ... as i16, but no idea about

213 |         self.inner.ut_type.try_into().unwrap()
    |                           ++++++++++++++++++++

error[E0609]: no field `ut_user` on type `libc::utmpx`
   --> src/uucore/src/lib/features/utmpx.rs:225:34
    |
225 |         chars2string!(self.inner.ut_user)
    |                                  ^^^^^^^ unknown field
    |
    = note: available fields are: `ut_name`, `ut_id`, `ut_line`, `ut_host`, `ut_session` ... and 5 others

[0323pin]

without

Ok but, default-features builds just fine. The only reason I'm trying to build with GNU make is to get separated uu- binaries rather than the multicall binary.

Building with GNU make detects the OS, changes the cargo build command and causes the failure.

But I see now that I can do that with cargo.

[0323pin]

Since default-features is working fine, I'll close this issue.

[oech3]

Please reopen. unix progs are still not buildable.

[0323pin]

Ok

[0323pin]

@oech3

but no idea about

I've looked for ut_user and it's not defined in Rust libc. The man page utmp and utmpx lead to the man page for endutxent where I can read the following:

The fields ut_user, ut_id, ut_line, ut_pid, ut_type, and
ut_tv conform to IEEE Std 1003.1-2001 (``POSIX.1'') (XSI extension), and
previously to X/Open Portability Guide Issue 4, Version 2 (``XPG4.2'').

I'm not on my NetBSD system right now but let me know if you would like me to check something.

[oech3]

I actually don't use *BSD. So PRs from me is very restricted.

[oech3]

What util does ut_user? We could use ut_name instead.
[Edit] We should fix uu_who at 1st.

[0323pin]

@oech3 I haven't look through the coreutils code to see which util is calling ut_user.

The issue here is that we have it but, it's not defined in Rust libc.

~> grep -r "ut_user" /usr/include/
/usr/include/rpcsvc/rusers.h:	char *ut_user;
/usr/include/rpcsvc/rusers.x:	string ut_user<RUSERS_MAXUSERLEN>;	/* aka ut_name */
/usr/include/utmpx.h:#define ut_user ut_name
~> grep -r "ut_name" /usr/include/
[...]
/usr/include/rpcsvc/rnusers.h: char ut_name[8]; /* user id */
/usr/include/rpcsvc/rnusers.x:%	char	ut_name[8];		/* user id */
/usr/include/rpcsvc/rnusers.x:%	ptr  = objp->ut_name;
/usr/include/rpcsvc/rnusers.x:%	size = (u_int)sizeof(objp->ut_name);
/usr/include/rpcsvc/rusers.x:	string ut_user<RUSERS_MAXUSERLEN>;	/* aka ut_name */
/usr/include/utmp.h:	char	ut_name[UT_NAMESIZE];
/usr/include/utmpx.h:#define ut_user ut_name
/usr/include/utmpx.h:	char ut_name[_UTX_USERSIZE];	/* login name */

EDIT: I wounder if these would help the other errors?

~> grep -r "BOOT_TIME" /usr/include/
/usr/include/rpcsvc/rusers.h:#define RUSERS_BOOT_TIME 2
/usr/include/rpcsvc/rusers.x:const	RUSERS_BOOT_TIME = 2;
/usr/include/utmpx.h:#define BOOT_TIME	2
~> grep -r "USER_PROCESS" /usr/include/
/usr/include/rpcsvc/rusers.h:#define RUSERS_USER_PROCESS 7
/usr/include/rpcsvc/rusers.x:const	RUSERS_USER_PROCESS = 7;
/usr/include/utmpx.h:#define USER_PROCESS	7

[oech3]

I think you can add cfg block to utmpx.rs to import some libc::conststs with cast as i64 and change a function using ut_user to ut_name.

I succeed to pass cargo check who at least for.

[0323pin]

I succeed to pass cargo check who at least for.

Do you have a draft PR? Or a fork of main with the changes? I can try a full local build.