From 7e42d84f568310f69472a39e0fe63de84998aa9a Mon Sep 17 00:00:00 2001 From: Mike Laumann Bellika <5175031+MikeBellika@users.noreply.github.com> Date: Mon, 19 Aug 2024 10:39:12 +0200 Subject: [PATCH] use `isHLSProvider` and `isDASHProvider`instead of manually checking type This provides better narrowing for typescript and prevents a type error when setting `provider.library` --- src/snippets/docs/player/api/providers/dash/wc/importing.ts | 3 ++- src/snippets/docs/player/api/providers/hls/wc/importing.ts | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/snippets/docs/player/api/providers/dash/wc/importing.ts b/src/snippets/docs/player/api/providers/dash/wc/importing.ts index 3a430af..8dcd2a9 100644 --- a/src/snippets/docs/player/api/providers/dash/wc/importing.ts +++ b/src/snippets/docs/player/api/providers/dash/wc/importing.ts @@ -1,8 +1,9 @@ import DASH from 'dashjs'; +import {isDASHProvider} from 'vidstack' player.addEventListener('provider-change', (event) => { const provider = event.detail; - if (provider?.type === 'dash') { + if (isDASHProvider(provider)) { // Static import provider.library = DASH; // Or, dynamic import diff --git a/src/snippets/docs/player/api/providers/hls/wc/importing.ts b/src/snippets/docs/player/api/providers/hls/wc/importing.ts index c67da92..67afef7 100644 --- a/src/snippets/docs/player/api/providers/hls/wc/importing.ts +++ b/src/snippets/docs/player/api/providers/hls/wc/importing.ts @@ -1,8 +1,9 @@ import HLS from 'hls.js'; +import {isHLSProvider} from 'vidstack' player.addEventListener('provider-change', (event) => { const provider = event.detail; - if (provider?.type === 'hls') { + if (isHLSProvider(provider)) { // Static import provider.library = HLS; // Or, dynamic import