Only warpify on WarpTerminal#162
Conversation
Without this change, on default terminal apps (e.g. macOS's terminal) it will show an urgly line per terminal process
```
Last login: Sun May 31 01:02:11 on ttys005
$f{"hook": "SourcedRcFileForWarp", "value": { "shell": "zsh"}}?%
```
The condition make the apply cleaner, test locally and works
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @syscl on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment |
|
@syscl is attempting to deploy a commit to the warpdotdev Team on Vercel. A member of the Team first needs to authorize it. |
|
This PR is not linked to an issue that is marked with Issue-state enforcement details:
To continue, link this PR to a same-repo issue such as Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is not linked to an issue that is marked with ready-to-implement.
Issue-state enforcement details:
-
Associated same-repo issues checked: none
-
Required readiness label:
ready-to-implement
To continue, link this PR to a same-repo issue such as Closes #123 in the PR description, and make sure that issue has ready-to-implement.
Powered by Oz
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
@oz-agent ready-to-implement |
kevinyang372
left a comment
kevinyang372
left a comment
There was a problem hiding this comment.
Thanks for contributing. Can you make sure to test these changes on these shells and post screenshots of them working?
|
|
||
| # For bash subshells, add to ~/.bashrc or ~/.bash_profile. | ||
| printf '\eP$f{"hook": "SourcedRcFileForWarp", "value": { "shell": "bash"}}\x9c' | ||
| if [[ "$TERM_PROGRAM" == "WarpTerminal" ]]; |
|
|
||
| # For fish subshells, add to ~/.config/fish/config.fish. | ||
| if status is-interactive | ||
| if status is-interactive and test "$TERM_PROGRAM" = "WarpTerminal" |
There was a problem hiding this comment.
I think and needs a statement separator (; or newline) before it
3 participants
Without this change, on default terminal apps (e.g. macOS's terminal) it will show an urgly line per terminal process
The condition make the apply cleaner, test locally and works
Summary
Related issues
#164
Validation
Screenshots
Follow-ups