From face195b6530271022b2be87abce12941622ad1e Mon Sep 17 00:00:00 2001 From: "Garen J. Torikian" Date: Tue, 13 Jan 2026 14:48:11 -0500 Subject: [PATCH] Correct params for `list_groups` and `list_users` --- src/workos/directory_sync.py | 16 ++++++++-------- src/workos/types/directory_sync/list_filters.py | 8 ++++---- tests/test_directory_sync.py | 8 ++++---- 3 files changed, 16 insertions(+), 16 deletions(-) diff --git a/src/workos/directory_sync.py b/src/workos/directory_sync.py index 8668e607..c727eabb 100644 --- a/src/workos/directory_sync.py +++ b/src/workos/directory_sync.py @@ -184,9 +184,9 @@ def list_users( } if group_id is not None: - list_params["group"] = group_id + list_params["group_id"] = group_id if directory_id is not None: - list_params["directory"] = directory_id + list_params["directory_id"] = directory_id response = self._http_client.request( "directory_users", @@ -218,9 +218,9 @@ def list_groups( } if user_id is not None: - list_params["user"] = user_id + list_params["user_id"] = user_id if directory_id is not None: - list_params["directory"] = directory_id + list_params["directory_id"] = directory_id response = self._http_client.request( "directory_groups", @@ -322,9 +322,9 @@ async def list_users( } if group_id is not None: - list_params["group"] = group_id + list_params["group_id"] = group_id if directory_id is not None: - list_params["directory"] = directory_id + list_params["directory_id"] = directory_id response = await self._http_client.request( "directory_users", @@ -355,9 +355,9 @@ async def list_groups( "order": order, } if user_id is not None: - list_params["user"] = user_id + list_params["user_id"] = user_id if directory_id is not None: - list_params["directory"] = directory_id + list_params["directory_id"] = directory_id response = await self._http_client.request( "directory_groups", diff --git a/src/workos/types/directory_sync/list_filters.py b/src/workos/types/directory_sync/list_filters.py index 2c98c954..01a1e9ba 100644 --- a/src/workos/types/directory_sync/list_filters.py +++ b/src/workos/types/directory_sync/list_filters.py @@ -12,10 +12,10 @@ class DirectoryUserListFilters( ListArgs, total=False, ): - group: Optional[str] - directory: Optional[str] + group_id: Optional[str] + directory_id: Optional[str] class DirectoryGroupListFilters(ListArgs, total=False): - user: Optional[str] - directory: Optional[str] + user_id: Optional[str] + directory_id: Optional[str] diff --git a/tests/test_directory_sync.py b/tests/test_directory_sync.py index 8a7a28f1..7a6f08fb 100644 --- a/tests/test_directory_sync.py +++ b/tests/test_directory_sync.py @@ -145,7 +145,7 @@ def test_list_users_with_directory( assert request_kwargs["url"].endswith("/directory_users") assert request_kwargs["method"] == "get" assert request_kwargs["params"] == { - "directory": "directory_id", + "directory_id": "directory_id", "limit": 10, "order": "desc", } @@ -163,7 +163,7 @@ def test_list_users_with_group( assert request_kwargs["url"].endswith("/directory_users") assert request_kwargs["method"] == "get" assert request_kwargs["params"] == { - "group": "directory_grp_id", + "group_id": "directory_grp_id", "limit": 10, "order": "desc", } @@ -181,7 +181,7 @@ def test_list_groups_with_directory( assert request_kwargs["url"].endswith("/directory_groups") assert request_kwargs["method"] == "get" assert request_kwargs["params"] == { - "directory": "directory_id", + "directory_id": "directory_id", "limit": 10, "order": "desc", } @@ -199,7 +199,7 @@ def test_list_groups_with_user( assert request_kwargs["url"].endswith("/directory_groups") assert request_kwargs["method"] == "get" assert request_kwargs["params"] == { - "user": "directory_user_id", + "user_id": "directory_user_id", "limit": 10, "order": "desc", }