From 45528b58a9c5aa7d8a964ccccc4872b8a2475c59 Mon Sep 17 00:00:00 2001 From: Pascal Birchler Date: Sun, 29 Mar 2026 15:32:30 +0200 Subject: [PATCH 1/5] Adjust quotes --- features/core.feature | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/features/core.feature b/features/core.feature index db3228f0..5fcdd75b 100644 --- a/features/core.feature +++ b/features/core.feature @@ -209,7 +209,7 @@ Feature: Manage WordPress installation """ And the return code should be 0 - When I run `wp eval 'echo $GLOBALS["current_site"]->domain;'` + When I run `wp eval "echo $GLOBALS['current_site']->domain;"` Then STDOUT should be: """ foobar.org From fd9ea85d1b266c91673a93f073a4f3225e26b7a3 Mon Sep 17 00:00:00 2001 From: Pascal Birchler Date: Sun, 29 Mar 2026 16:22:01 +0200 Subject: [PATCH 2/5] escape --- features/core.feature | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/features/core.feature b/features/core.feature index 5fcdd75b..1ea1520b 100644 --- a/features/core.feature +++ b/features/core.feature @@ -209,7 +209,7 @@ Feature: Manage WordPress installation """ And the return code should be 0 - When I run `wp eval "echo $GLOBALS['current_site']->domain;"` + When I run `wp eval "echo \$GLOBALS['current_site']->domain;"` Then STDOUT should be: """ foobar.org From 0dce7a4edd1bf38227398981cd380473fcadf3d3 Mon Sep 17 00:00:00 2001 From: Pascal Birchler Date: Wed, 1 Apr 2026 16:29:22 +0200 Subject: [PATCH 3/5] Use eval-file --- features/core.feature | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/features/core.feature b/features/core.feature index 1ea1520b..df8fe030 100644 --- a/features/core.feature +++ b/features/core.feature @@ -209,7 +209,12 @@ Feature: Manage WordPress installation """ And the return code should be 0 - When I run `wp eval "echo \$GLOBALS['current_site']->domain;"` + Given a current-site-domain.php file: + """ + domain; + """ + When I run `wp eval-file current-site-domain` Then STDOUT should be: """ foobar.org From 090f1066ab2f54beaf8113c32255891adebcc747 Mon Sep 17 00:00:00 2001 From: Pascal Birchler Date: Wed, 1 Apr 2026 23:18:20 +0200 Subject: [PATCH 4/5] Update features/core.feature MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Wojciech SmoliƄski --- features/core.feature | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/features/core.feature b/features/core.feature index df8fe030..311eb2c6 100644 --- a/features/core.feature +++ b/features/core.feature @@ -214,7 +214,7 @@ Feature: Manage WordPress installation domain; """ - When I run `wp eval-file current-site-domain` + When I run `wp eval-file current-site-domain.php` Then STDOUT should be: """ foobar.org From 55280a24aed860195638d013faa14604f5cea63d Mon Sep 17 00:00:00 2001 From: Pascal Birchler Date: Thu, 2 Apr 2026 10:20:17 +0200 Subject: [PATCH 5/5] Skip some more tests on Windows --- features/core-download.feature | 4 ++++ features/core.feature | 1 + 2 files changed, 5 insertions(+) diff --git a/features/core-download.feature b/features/core-download.feature index 52912266..7c53c1ec 100644 --- a/features/core-download.feature +++ b/features/core-download.feature @@ -386,6 +386,10 @@ Feature: Download WordPress """ And the return code should be 1 + @skip-windows + Scenario: Fail if path can't be created (root-level-directory) + Given an empty directory + When I try `wp core download --path=/root-level-directory` Then STDERR should contain: """ diff --git a/features/core.feature b/features/core.feature index 311eb2c6..4918f74c 100644 --- a/features/core.feature +++ b/features/core.feature @@ -301,6 +301,7 @@ Feature: Manage WordPress installation http://localhost:8001 """ + @skip-windows Scenario: Test output in a multisite install with custom base path Given a WP install