Remove validator for enterprise blobber deployment#172
Open
Jayashsatolia403 wants to merge 2 commits intomainfrom
Open
Remove validator for enterprise blobber deployment#172Jayashsatolia403 wants to merge 2 commits intomainfrom
Jayashsatolia403 wants to merge 2 commits intomainfrom
Conversation
…y, which will break enterprise deployments (no validator service). This link entry should be removed or wrapped under the non-enterprise check. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR removes the validator functionality for enterprise blobber deployments by conditionally executing validator-related commands and configuration changes only when not in enterprise mode.
- Conditionally bypasses wallet creation for validator operations in enterprise deployments.
- Conditionally adds validator routes and services (and related dependencies) only for non-enterprise deployments.
- Updates the docker-compose and Caddyfile configurations with sed commands and heredoc blocks based on deployment type.
Comments suppressed due to low confidence (1)
chimney.sh:304
- The EOF delimiter for the heredoc is indented. For better shell compatibility and to avoid unexpected behavior, consider aligning the EOF marker to the start of the line.
EOF
Comment on lines
+523
to
+524
| sed -i '/depends_on:/a\ - validator' ${PROJECT_ROOT}/docker-compose.yml | ||
| sed -i '/links:/a\ - validator:validator' ${PROJECT_ROOT}/docker-compose.yml |
There was a problem hiding this comment.
Appending the validator dependency via sed may introduce duplicate lines on multiple executions; consider checking if the line already exists before appending it.
Suggested change
| sed -i '/depends_on:/a\ - validator' ${PROJECT_ROOT}/docker-compose.yml | |
| sed -i '/links:/a\ - validator:validator' ${PROJECT_ROOT}/docker-compose.yml | |
| if ! grep -q ' - validator' ${PROJECT_ROOT}/docker-compose.yml; then | |
| sed -i '/depends_on:/a\ - validator' ${PROJECT_ROOT}/docker-compose.yml | |
| fi | |
| if ! grep -q ' - validator:validator' ${PROJECT_ROOT}/docker-compose.yml; then | |
| sed -i '/links:/a\ - validator:validator' ${PROJECT_ROOT}/docker-compose.yml | |
| fi |
| fi | ||
| ./bin/zwallet create-wallet --wallet blob_op_wallet.json --configDir . --config config.yaml --silent | ||
| ./bin/zwallet create-wallet --wallet vald_op_wallet.json --configDir . --config config.yaml --silent | ||
| if [ "$IS_ENTERPRISE" != true ]; then |
There was a problem hiding this comment.
[nitpick] The repeated check for 'if [ "$IS_ENTERPRISE" != true ]' across multiple diff sections suggests an opportunity to refactor this condition into a variable or function to enhance consistency and maintainability.
Suggested change
| if [ "$IS_ENTERPRISE" != true ]; then | |
| if [ "$IS_NOT_ENTERPRISE" = true ]; then |
Chetas1
reviewed
Jun 23, 2025
Contributor
Chetas1
left a comment
Chetas1
left a comment
There was a problem hiding this comment.
Line no -> 196 needs to be under condition of non-enterprise
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.