feat: Add allowedOrigins config for openclaw#12162
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9048ae11d9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| setBrowserConfig(conf, browserConfig{ | ||
| Enabled: config.BrowserEnabled, | ||
| ExecutablePath: defaultBrowserExecutablePath, | ||
| Headless: true, | ||
| NoSandbox: true, |
There was a problem hiding this comment.
Saving the "Other" form now rewrites the full browser block with hard-coded values, so a user changing only timezone/browser-enabled can unintentionally lose existing headless, noSandbox, and profile behavior that was previously configurable. This is a regression for existing agents that already have non-default browser settings (from earlier UI versions or manual config edits), because an unrelated settings save silently mutates runtime browser behavior.
Useful? React with 👍 / 👎.
| if (!target || !port) { | ||
| return ''; | ||
| } | ||
| return `http://${target}:${port}`; |
There was a problem hiding this comment.
The default origin builder concatenates systemIP directly into http://<ip>:<port>, which produces invalid URLs for IPv6 values (for example http://2001:db8::1:18789 instead of bracketed host form). In IPv6 environments this makes the auto-filled allowed-origins value invalid and fails validation in the create flow unless users manually fix the format.
Useful? React with 👍 / 👎.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wanghe-fit2cloud The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
No description provided.