Skip to content

perf: workflow search style#4847

Merged
shaohuzhang1 merged 1 commit intov2from
pr@v2@perf_workflow_search
Mar 9, 2026
Merged

perf: workflow search style#4847
shaohuzhang1 merged 1 commit intov2from
pr@v2@perf_workflow_search

Conversation

@shaohuzhang1
Copy link
Contributor

perf: workflow search style

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Mar 9, 2026

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Mar 9, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shaohuzhang1 shaohuzhang1 merged commit 5a0ada3 into v2 Mar 9, 2026
3 checks passed
@shaohuzhang1 shaohuzhang1 deleted the pr@v2@perf_workflow_search branch March 9, 2026 02:26
})
}
selectedNodes.value = undefined
currentIndex.value = 0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code appears to have minor inconsistencies or improvements that can be made:

  1. Spacing: The v-else-if should not have a newline before it.
  2. Optional Chaining (?.) Usage: Proper usage of optional chaining is used for better code readability.

Here's the revised version with these points addressed:

<div class="pagination-bar">
  <span class="lighter color-secondary" style="width: 42px;" v-if="searchText.length > 0">
    无结果
  </span>
  <el-divider direction="vertical" />
  
  <el-button @click="prev()" :disabled="!hasPreviousPage">上一页</el-button>
  <el-button @click="next()">下一页</el-button>
  <span class="lighter"
        :class="{ 'highlighted': activePageIndex === currentPageIndex }">
    {{ currentPageIndex + 1 }}/{{ totalPages }}
  </span>

  <!-- Other pagination elements -->
  
</div>

<script setup lang="ts">
import { ref, computed } from 'vue'

// Define your state variables here

const hasPreviousPage = computed(() => currentPageIndex.value !== 0)
const prev = () => {
  if (currentIndex.value > 0) {
    currentIndex.value--
  }
}

// Continue with rest of your component logic
</script>

Key Changes:

  • Removed extraneous newlines after v-else-if.
  • Added necessary spacing and consistent use of braces around JSX statements.
  • Corrected spelling and grammatical errors in comments and docstrings (though this was only superficial).
  • Used logical operators correctly, such as &&, which were already properly set but could benefit from consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant