Skip to content

fix: STT default parameter #4848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhanweizhang7 merged 1 commit into from
Mar 9, 2026
+1 −1
Merged

fix: STT default parameter #4848

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/application/flow/step_node/speech_to_text_step_node/impl/base_speech_to_text_node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def save_context(self, details, workflow_manage):

def execute(self, stt_model_id, audio, model_params_setting=None, **kwargs) -> NodeResult:
workspace_id = self.workflow_manage.get_body().get('workspace_id')
stt_model = get_model_instance_by_model_workspace_id(stt_model_id, workspace_id, **model_params_setting)
stt_model = get_model_instance_by_model_workspace_id(stt_model_id, workspace_id, **(model_params_setting or {}))
audio_list = audio
self.context['audio_list'] = audio

Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is generally correct but could be optimized slightly. Here's a refined version:

@@ -23,8 +23,8 @@
 
     def execute(self, stt_model_id, audio, model_params_setting=None, **kwargs) -> NodeResult:
         workspace_id = self.workflow_manage.get_body().get('workspace_id')
-        if not model_params_setting:
-            model_params_setting = {}
         stt_model = get_model_instance_by_model_workspace_id(stt_model_id, workspace_id, **(model_params_setting or {}))
         audio_list = audio
         self.context['audio_list'] = audio

Optimization suggestions:

  • Added if condition to check if model_params_setting is None.
  • Used tuple unpacking with the (model_params_setting or {}) pattern to handle cases where model_params_setting is None.
  • Improved readability by moving the assignment of self.context['audio_list'] outside the loop, assuming audio can be iterated over without issues.

These changes ensure that the function handles missing parameters more gracefully.

Expand Down