Skip to content

fix: Folder tree drag error #4849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhanweizhang7 merged 1 commit into from
Mar 9, 2026
+1 −1
Merged

fix: Folder tree drag error #4849

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/src/components/folder-tree/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,7 @@ const handleDrop = (draggingNode: any, dropNode: any, dropType: string, ev: Drag
folderApi
.putFolder(dragData.id, props.source, obj, loading)
.then(() => {
sortAfterDrop(dragData, dropData, dropType, newParentId)
emit('refreshTree')

MsgSuccess(t('common.saveSuccess'))
})
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code provided appears to be handling a drag-and-drop operation within an application where files or folders are being moved from one location to another. Several points can be considered:

  1. Code Suggestion: Consider using await before calling asynchronous methods like folderApi. This can make the code more readable and easier to debug. For example:

    await folderApi.putFolder(dragData.id, props.source, obj, loading);

  2. Potential Issues:

    • If sortAfterDrop fails due to some reason but MsgSuccess is still called, it might leave the user unsure about the outcome of their action.
    • Not handling errors properly could lead to silent failures if something goes wrong.

  3. Optimization Suggestions:

    • Ensure that all functions involved (e.g., handleDrop, emit function) are already defined before they are used inside this block. Otherwise, you will get runtime errors.
    • If there are multiple calls to other functions, consider moving them into separate utility functions or higher-order components for better maintainability and reusability.
    • Consider logging detailed messages at various steps or wrapping the entire logic in a try-catch block to catch potential exceptions gracefully.

If you have specific error handling needs or further modifications required based on your app's context, please let me know!

Expand Down