Skip to content

fix: The search and positioning status is incorrect. By default, only the node being located needs to be selected, and not all nodes found in the search need to be selected #4863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Mar 11, 2026
Merged

fix: The search and positioning status is incorrect. By default, only the node being located needs to be selected, and not all nodes found in the search need to be selected #4863

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions ui/src/workflow/common/NodeContainer.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,26 +443,24 @@ const closeNodeMenu = () => {
const keyWord = ref('')
const currentKeyWord = ref(false)
const selectOn = (kw: string) => {
props.nodeModel.setSelected(true)
keyWord.value = kw
props.nodeModel.isSelected = false
currentKeyWord.value = false
console.log('selectOn', kw)
}
/**
* 定位时触发
* @param kw
*/
const focusOn = (kw: string) => {
props.nodeModel.setSelected(true)
currentKeyWord.value = true
console.log('focusOn', kw)
}
/**
* 清除时触发
*/
const clearSelectOn = () => {
keyWord.value = ''
currentKeyWord.value = false
console.log('onClearSearchSelect')
}

// 高亮选中关键字
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the provided code snippet, there are several areas that could be improved:

  1. Redundant Code: The props.nodeModel.setSelected(true) line is duplicated in both selectOn and focusOn. It should only be executed once if necessary.

  2. Variable Consistency: The naming convention for variables like keyWord, currentKeyWord, and their properties can be more consistent to help with readability and reduce errors.

  3. Log Statements Simplification: Instead of logging the keyword every time it changes, consider using console.debug() or remove it altogether unless debugging is needed.

  4. Documentation and Comments: Add comments explaining the purpose of each function and variable to improve maintainability.

  5. Use Cases: Consider how these functions might be used outside of the context shown here to ensure they cover all use cases efficiently.

Here's an optimized version of the code with some of these improvements:

import { ref } from 'vue';

export default {
  setup(props) {
    const keyWord = ref('');
    const currentKeyWord = ref(false);

    const selectOn = (kw: string) => {
      props.nodeModel.selected = true;
      keyWord.value = kw;
      currentKeyWord.value = false;
      console.log('selected', kw);
    };

    const focusOn = (kw: string) => {
      props.nodeModel.selected = true;
      currentKeyWord.value = true;
      console.log('focused on', kw);
    };

    const clearSelectOn = () => {
      keyWord.value = '';
      currentKeyWord.value = false;
      console.log('cleared search selection');
    };

    return {
      keyWord,
      currentKeyWord,
      selectOn,
      focusOn,
      clearSelectOn,
    };
  },
};

These optimizations make the code cleaner and easier to maintain.

Expand Down