Skip to content

Conversation

@tkan145
Copy link
Contributor

@tkan145 tkan145 commented Nov 15, 2024

What

Backport #1505 to 2.15 branch

Performing a match on a nil value results in an exception being thrown
and bypassing the entire authorization validation process.
@tkan145 tkan145 requested a review from a team as a code owner November 15, 2024 00:26
@tkan145 tkan145 changed the title [http_authorization] Check for nil value when decode based64 value [THREESCALE-11435] Check for nil value when decode based64 value Nov 15, 2024
@eguzki
Copy link
Member

eguzki commented Nov 15, 2024

@tkan145
Copy link
Contributor Author

tkan145 commented Nov 18, 2024

It is failing http://search.cpan.org/~agent/Test-Nginx/lib/Test/Nginx/Socket.pm

Maybe replace that with https://metacpan.org/pod/Test::Nginx

I will address this with the next PR, need to fix on the main branch too

@tkan145 tkan145 merged commit a95ab3a into 3scale:3scale-2.15-stable Nov 18, 2024
4 of 5 checks passed
@tkan145 tkan145 deleted the backport-THREESCALE-11435-2.15 branch November 18, 2024 02:33
This was referenced Nov 18, 2024
@tkan145 tkan145 restored the backport-THREESCALE-11435-2.15 branch June 10, 2025 02:32
@tkan145 tkan145 deleted the backport-THREESCALE-11435-2.15 branch June 10, 2025 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants