feat: tree-shake unused extension free functions from export#8624
Open
malec-palec wants to merge 1 commit into
Open
feat: tree-shake unused extension free functions from export#8624malec-palec wants to merge 1 commit into
malec-palec wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.jsfiles (onFirstSceneLoaded,onSceneLoaded, etc.) as mandatory extension-wide includes.Previously, using any single free function (or behavior/object) from an extension pulled ALL free function
.jsfiles into the build viaextensionIncludeFiles. This was a conservative safety net that is redundant - the code generation pass already records transitive include dependencies per-function.Why this is safe
onFirstSceneLoaded,onScenePreEvents, etc. self-register viagdjs._registerCallback()at load time and are never referenced through event instructions; they remain in the mandatory include list..jsis included via their own metadata when the type is present in the project.