Update Dynamo CRDs helm install flag and fix serviceaccount command#241
Open
leonardchan wants to merge 1 commit into
Open
Update Dynamo CRDs helm install flag and fix serviceaccount command#241leonardchan wants to merge 1 commit into
leonardchan wants to merge 1 commit into
Conversation
- Update --atomic to --rollback-on-failure in a4x and a3ultra Dynamo READMEs. - Fix missing -n flag in kubectl get serviceaccounts command in a4x Dynamo README.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the Helm installation commands for Dynamo CRDs in the READMEs to use
--rollback-on-failureinstead of--atomic, and fixes akubectlcommand that was missing the-nflag for listing service accounts.Changes:
inference/a4x/disaggregated-serving/dynamo/README.md:--atomicto--rollback-on-failurekubectl get serviceaccountscommand to include-n ${NAMESPACE}instead of passing${NAMESPACE}as a positional argument.inference/a3ultra/disaggregated-serving/dynamo/README.md:--atomicto--rollback-on-failureThe change from
--atomicto--rollback-on-failureis made because--atomicis being deprecated in favor of--rollback-on-failurein newer Helm conventions (such as Helm 4).--rollback-on-failureexplicitly conveys the intent to roll back changes on failure and is the preferred modern flag for this behavior.These updates ensure consistent and preferred rollback behavior during CRD installation failures, and fix a broken troubleshooting command.