Validate APCB Token before applying PATCH#60
Open
ankitaprasad2206 wants to merge 1 commit intointeg_sp8from
Open
Validate APCB Token before applying PATCH#60ankitaprasad2206 wants to merge 1 commit intointeg_sp8from
ankitaprasad2206 wants to merge 1 commit intointeg_sp8from
Conversation
There is a corner case where, if invalid APCB Token is passed through Redfish, the operation should throw invalid error. Tested: tested on Kenya system. PATCH is failing for invalid tokens. Signed-off-by: ankprasa <ankprasa@amd.com>
raja-gade
reviewed
Apr 8, 2026
| const sdbusplus::message_t&, const ObjectPath& objPath) { | ||
| if (ec) | ||
| { | ||
| BMCWEB_LOG_ERROR("RDE: operationGet failed: {}", |
Collaborator
There was a problem hiding this comment.
Suggested change
| BMCWEB_LOG_ERROR("RDE: operationGet failed: {}", | |
| BMCWEB_LOG_ERROR("RDE: operationPATCH failed: {}", |
??
| rdeEncodingFormatJSON, self->schema); | ||
| }; | ||
|
|
||
| if (self->subUri != socConfigurationTokenSubUri) |
Collaborator
There was a problem hiding this comment.
May I know what this check is for?
Collaborator
Author
There was a problem hiding this comment.
This check is for other URI which is not "Oem/AMD/SocConfiguration/Token". For such URIs, no need to call validateSocConfigurationPatchTokenKeys() and startPatchOperation() can be directly called.
| auto expectedTokenIt = payloadTokenMap.find(key); | ||
| if (key.empty() || expectedTokenIt == payloadTokenMap.end()) | ||
| { | ||
| messages::propertyValueIncorrect(response, key, value); |
Collaborator
There was a problem hiding this comment.
NIT:
Please add a log in error cases. It will be useful during the debug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a corner case where, if invalid APCB Token is passed through Redfish, the operation should throw invalid error.
Tested: tested on Kenya system. PATCH is failing
for invalid tokens.