Conversation
- Driver now gives correct readings for rails 1 and 2 - Driver no longer advertises rail 2 power in Tested: - Nigeria-2690 - Falcon-FPGC Signed-off-by: Ryan Ilgen <Ryan.Ilgen@amd.com>
modolaty
reviewed
Apr 9, 2026
Collaborator
modolaty
left a comment
modolaty
left a comment
There was a problem hiding this comment.
Please change tested to indicate SP7 Nigeria and SP8 Falcon
| ret = mp2869_voltage_vout_gain_get(client, data); | ||
| if (ret) | ||
| return ret; | ||
| return ret; |
Collaborator
There was a problem hiding this comment.
Nit: please remove the extra space
| #define MP2869_MFR_VOUT_SCALE_LOOP 0x29 | ||
| #define MP2869_IIN_SCALE_BIT_R1 0x53 | ||
| #define MP2869_IOUT_SCALE_BIT 0x67 | ||
| #define MP2869_MFR_PWR_RPT_R1 0x68 |
Collaborator
There was a problem hiding this comment.
where is this new parameter is used?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested: