-
Notifications
You must be signed in to change notification settings - Fork 33
Add multi-part operations for asymmetric signature #335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
This needs to wait for the 1.4.1 publication to be finalised. One aspect of the proposed API that might be debatable:
|
3ffb7f7 to
a2c823f
Compare
MarcusJGStreets
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks to be the obvious way to implement multipart sign and verify.
A fair counter-argument can be made for a separate function for a context based on the following observations:
So I will update this PR to pass the context in an optional |
Likewise for the multi-part verify operation.
a2c823f to
1028873
Compare
This adds the new operations for multipart sign and multi-part verify for asymmetric signatures (previous discussions suggested these should be ditinct types).
Fixes #319