Skip to content

fix: prevent Ctrl+V in dialogs from pasting into editor #2018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bajrangCoder merged 1 commit into from
Apr 8, 2026
Merged

fix: prevent Ctrl+V in dialogs from pasting into editor #2018

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion src/handlers/keyboard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export default function keyboardHandler(e) {
const $target = e.target;
const { key, ctrlKey, shiftKey, altKey, metaKey } = e;

if ($target instanceof HTMLTextAreaElement) {
if (shouldIgnoreEditorShortcutTarget($target)) {
keydownState.esc = key === "Escape";
return;
}
Expand All @@ -81,6 +81,24 @@ export default function keyboardHandler(e) {
target?.dispatchEvent?.(event);
}

/**
* Returns true when a keyboard event target should keep the shortcut local
* instead of forwarding it into the editor.
* @param {EventTarget | null} target
* @returns {boolean}
*/
function shouldIgnoreEditorShortcutTarget(target) {
if (!(target instanceof Element)) return false;

return (
target instanceof HTMLInputElement ||
target instanceof HTMLTextAreaElement ||
target instanceof HTMLSelectElement ||
target.isContentEditable ||
!!target.closest(".prompt, #palette")
);
}

document.addEventListener("admob.banner.size", async (event) => {
const { height } = event.size;
MIN_KEYBOARD_HEIGHT = height + 10;
Expand Down