chore(CI): force Node24 for JS actions and use env APK paths

[UnschooledGamer]

Set FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 for JS-based actions to avoid GitHub Actions Node 20 deprecation. Add NORMAL_APK_PATH and FDROID_APK_PATH
env vars and use them for building, uploading, and releasing APKs. Also fix STORE_FILE_PATH/BUILD_JSON_PATH expansions and add debug echo lines.

[UnschooledGamer]

🤔🤔🤔

[greptile-apps]

Greptile Summary

This PR addresses Node 20 deprecation warnings by setting FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true on JS-based action steps, and introduces NORMAL_APK_PATH/FDROID_APK_PATH env vars that are now set dynamically (after UPDATED_VERSION is known), fixing the previous timing bug. It also corrects the files: field in the release step, where bare $UPDATED_VERSION was never shell-expanded in a YAML scalar context.

Confidence Score: 5/5

Safe to merge — the prior P1 timing bug is correctly fixed and no new blocking issues were introduced.

Both previously-flagged concerns (UPDATED_VERSION timing and FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 coverage) are addressed. The only new finding is a P2: two debug echo lines placed before the env vars they reference are set, so they always print empty strings. This has no impact on the build or release outcomes.

No files require special attention.

Vulnerabilities

No security concerns identified.

Important Files Changed

Filename	Overview
.github/workflows/nightly-build.yml	Introduces NORMAL_APK_PATH/FDROID_APK_PATH env vars set dynamically after UPDATED_VERSION is known (fixing the previous timing bug), switches APK file references to use GHA expression syntax (fixing the broken $UPDATED_VERSION in YAML files: field), adds FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 to the release step, and adds debug echo lines that will always show empty values in the early logging step.
.github/workflows/community-release-notifier.yml	Adds FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true to the two JS-based actions (gh-truncate-string-action and discord-webhook) to suppress Node 20 deprecation warnings; no functional changes otherwise.

Sequence Diagram

sequenceDiagram
    participant WF as Workflow Start
    participant LS as Logging & Summaries
    participant AV as Append Commit Hash
    participant BN as Build Normal APK
    participant BF as Build F-Droid APK
    participant UA as Upload Artifact(s)
    participant R as Release (softprops)

    WF->>LS: NORMAL_APK_PATH not set yet
    WF->>LS: FDROID_APK_PATH not set yet
    LS-->>WF: echo lines output empty values
    WF->>AV: Compute UPDATED_VERSION
    AV->>AV: echo NORMAL_APK_PATH >> $GITHUB_ENV
    AV->>AV: echo FDROID_APK_PATH >> $GITHUB_ENV
    AV->>BN: NORMAL_APK_PATH now available
    BN->>BN: mv app-debug.apk to NORMAL_APK_PATH
    BN->>BF: FDROID_APK_PATH now available
    BF->>BF: mv app-debug.apk to FDROID_APK_PATH
    BF->>UA: Upload using env paths
    UA->>R: Release with NORMAL_APK_PATH and FDROID_APK_PATH

Loading

_{Reviews (2): Last reviewed commit: "Merge branch 'ci/improve-paths-fix-actio..." | Re-trigger Greptile}

[UnschooledGamer]

@greptile review again

[greptile-apps]

Tip:

Greploop — Automatically fix all review issues by running /greploops in Claude Code. It iterates: fix, push, re-review, repeat until 5/5 confidence.

Use the Greptile plugin for Claude Code to query reviews, search comments, and manage custom context directly from your terminal.

[UnschooledGamer]

Great.