Escape brackets in plaintext templates #101
Open
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Text bodies are previewed as if they were HTML. This works mostly, but no if the text contains < or >. It is common practice to wrap links in plaintext mail with <>. Currently, the preview hides these links, as the browser interprets them as (unknown) HTML tags. This fixes that.
jvhellemond
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plaintext templates are previewed as if they were HTML*. This works mostly, but not if the templates contains < or >. It is common practice to wrap links in plaintext mail with <>. Currently, the preview hides these links, as the browser interprets them as (unknown) HTML tags. This fixes that.
(* It would perhaps be better to preview these in an iframe as real plaintext, to better emulate a plaintext mail client.)