Fix: Make header sticky on desktop.#848
Conversation
Greptile SummaryThis PR extends the sticky header behavior from Android-only to all platforms by hardcoding
Confidence Score: 5/5Safe to merge — the change is a single-line toggle that enables already-tested sticky-header infrastructure on desktop. The existing BootstrapVue fixed=top prop and the .fixed-top-padding spacer were already working correctly on Android, so extending them unconditionally to all platforms is low-risk. The only finding is a now-stale inline comment. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Header component mounted] --> B{fixedTopMenu?}
B -- "Before: this.$isAndroid" --> C{Running on Android?}
C -- Yes --> D[fixed='top' navbar + fixed-top-padding class]
C -- No --> E[Standard in-flow navbar, no padding spacer]
B -- "After: true always" --> D
D --> F[Sticky header at top of viewport, 3.5em spacer div below]
E --> G[Header scrolls with page]
Reviews (1): Last reviewed commit: "Fix: Make header sticky on desktop." | Re-trigger Greptile |
| // Make configurable? | ||
| fixedTopMenu: this.$isAndroid, | ||
| fixedTopMenu: true, |
There was a problem hiding this comment.
The comment
// Make configurable? is now stale — the value is unconditionally true and no longer derived from any condition, so the question of configurability is less relevant. Consider removing or updating the comment to reflect the intent.
| // Make configurable? | |
| fixedTopMenu: this.$isAndroid, | |
| fixedTopMenu: true, | |
| fixedTopMenu: true, |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #848 +/- ##
=======================================
Coverage 34.38% 34.38%
=======================================
Files 36 36
Lines 2114 2114
Branches 403 386 -17
=======================================
Hits 727 727
- Misses 1308 1366 +58
+ Partials 79 21 -58 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Make the header sticky on desktop.
The header was already sticky on mobile. This extends that behavior to desktop as well.
Fixes #299