feat(sdlc): primitive taxonomy — agents, git skill, env-management#86
feat(sdlc): primitive taxonomy — agents, git skill, env-management#86NeuralEmpowerment merged 2 commits intomainfrom
Conversation
- README: define Commands/Skills/Agents/Hooks/Lib as explicit primitives with dual-mode philosophy (human-in-loop + headless workspaces) and composition diagram showing how they wire together - agents/env-reviewer: read-only specialist agent (disallowedTools: Write, Edit, MultiEdit) for auditing env var configuration quality - skills/git: consolidated git skill covering push, merge, worktree, fetch, PR lifecycle — replaces need for 8 individual operations - skills/env-management: three-component pattern (typed config → generate .env.example → fail fast on startup) with Python reference implementation using pydantic-settings - plugin table: add Agents column, reflect all current commands/skills
There was a problem hiding this comment.
Pull request overview
This PR introduces a comprehensive primitive taxonomy for the agentic-primitives repository, establishing a clear architectural foundation for AI agent systems with dual-mode operation (human-in-the-loop and headless workspaces).
Changes:
- Adds explicit primitive taxonomy to README with composition diagram showing how Commands, Skills, Agents, Hooks, and Lib components interact
- Introduces
env-revieweragent for read-only environment configuration audits with enforced tool scoping - Creates consolidated
gitskill covering push, merge, worktree, fetch, and PR lifecycle operations - Adds comprehensive
env-managementskill with full Python reference implementation for auto-generated .env files
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Adds primitive taxonomy section explaining Commands, Skills, Agents, Hooks, and Lib components; includes composition diagram and updates plugin table with Agents column |
| plugins/sdlc/agents/env-reviewer/agent.md | New read-only specialist agent for auditing environment variable configuration with explicit tool constraints |
| plugins/sdlc/skills/git/SKILL.md | Consolidated git workflow skill covering push, merge, worktree, fetch, and PR operations with intent-driven automation |
| plugins/sdlc/skills/env-management/SKILL.md | Comprehensive skill documentation for environment management pattern with three-component architecture |
| plugins/sdlc/skills/env-management/references/python/generate_env_example.py | Full Python reference implementation using pydantic-settings for idempotent .env generation and synchronization |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| --- | ||
| name: env-reviewer | ||
| description: Audits environment variable configuration for correctness, security, and completeness. Delegate to this agent when you need to review .env.example, settings classes, startup validation, or secret handling. Read-only — cannot modify files. | ||
| tools: Read, Grep, Glob, Bash |
There was a problem hiding this comment.
The frontmatter uses tools: but the existing agent (browser-qa-agent.md) uses allowed-tools:. For consistency across agent definitions, this should use allowed-tools: instead of tools:.
| tools: Read, Grep, Glob, Bash | |
| allowed-tools: Read, Grep, Glob, Bash |
| ├─► PreToolUse Hook validates git commands before execution | ||
| │ | ||
| ├─► Skill delegates review to env-reviewer Agent (Task tool) | ||
| │ ├─ tools: Read, Grep, Glob only (cannot modify anything) |
There was a problem hiding this comment.
The composition diagram states the env-reviewer agent has "tools: Read, Grep, Glob only" but the actual agent frontmatter specifies "Read, Grep, Glob, Bash". The README should be updated to include Bash in the list, or the agent should not include Bash if it's truly meant to be read-only. Since Bash is listed in the agent frontmatter and can execute arbitrary commands, this is inconsistent with the "read-only" design stated in the README diagram.
* feat(sdlc): add primitive taxonomy — agents, git skill, env-management - README: define Commands/Skills/Agents/Hooks/Lib as explicit primitives with dual-mode philosophy (human-in-loop + headless workspaces) and composition diagram showing how they wire together - agents/env-reviewer: read-only specialist agent (disallowedTools: Write, Edit, MultiEdit) for auditing env var configuration quality - skills/git: consolidated git skill covering push, merge, worktree, fetch, PR lifecycle — replaces need for 8 individual operations - skills/env-management: three-component pattern (typed config → generate .env.example → fail fast on startup) with Python reference implementation using pydantic-settings - plugin table: add Agents column, reflect all current commands/skills * fix(sdlc): bump plugin version to 1.3.0
Summary
agents/env-reviewer: New read-only specialist agent.disallowedTools: Write, Edit, MultiEditenforces least-privilege — audits env config, cannot touch files.skills/git: One consolidated git skill covering push, merge, worktree, fetch, and PR lifecycle. Intent-driven, headless-friendly. The explicit/sdlc:git_*commands stay for human-in-loop control.skills/env-management: Three-component pattern (typed config class → auto-generated.env.example→ fail-fast startup validation). Full Python reference implementation using pydantic-settings with idempotent.envsync andexclude=for runtime-discovered fields.Design philosophy
Primitives serve two contexts:
/sdlc:git_pushexplicitly, stays in controlgitskill, no human present — tool scoping and hooks are the safety layerThe same primitives work in both. The difference is configuration.
Test plan
agents/env-reviewerfrontmatter valid (tools/disallowedTools/model fields)skills/git/SKILL.mdcovers all git operations via ACTION parameterskills/env-management/references/python/generate_env_example.pyruns without import errors (after adapting imports)