Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Adds a set of design documents describing the newly introduced folders entity, how it integrates with legacy applications (app_db.folder_id) on this branch, and how it bridges to the artifact-based application model on the main branch.
Changes:
- Add an RFC documenting folder data model, API surface, and migration-bridge strategy to artifacts.
- Add a PRD capturing goals, requirements, and risks for folder-based organization.
- Add README/PR-style docs to orient reviewers and summarize implementation + validation steps.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| docs/designs/folders/RFC.md | Technical RFC covering current branch behavior, mainline artifact extension, and migration/compat strategy. |
| docs/designs/folders/README.md | Entry-point index explaining why the folder docs exist and how to navigate them. |
| docs/designs/folders/PRD.md | Product requirements and success criteria for folder organization. |
| docs/designs/folders/PR.md | Reviewer-facing summary including change inventory, risks, and validation guidance. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - New entity: `folders` | ||
| - Legacy entity still in use on this branch: `app_db` | ||
| - Mainline extension (already on `origin/main`): artifact-based application model | ||
|
|
There was a problem hiding this comment.
These docs refer to the main branch as origin/main, which is a remote-specific ref and can be confusing in forks/local setups. Consider using main (or “the main branch”) consistently, and optionally link to the relevant migration IDs/paths for precision.
| This branch introduces a first-class `folders` entity and connects it to legacy applications via `app_db.folder_id`. | ||
|
|
||
| `origin/main` has progressed toward artifact-based applications (workflow-backed application entities), with folder scope being extended to artifact tables. | ||
| We need a coherent design that supports current branch behavior and the migration target. |
There was a problem hiding this comment.
Using origin/main in design docs is a remote-specific git ref; readers may not have an origin remote or may use a different default branch name. Consider changing this to main / “main branch” (and keep the migration IDs as the stable reference).
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
dosubot
Bot
added
the
size:L
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ref: folders branch already merged