[Frontend / Fix]: Fix name memoization issues in entity commit modal#4412
[Frontend / Fix]: Fix name memoization issues in entity commit modal#4412ardaerzin wants to merge 1 commit into
Conversation
Prefer externalEntity over currentEntity when computing createFieldsEntity to avoid stale atom data from previous sessions where afterClose reset never fired (e.g. parent unmounted mid-animation). This ensures Effect 2's default-name computation uses fresh data on first open.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe PR fixes a controlled-mode bug in ChangesEntity Modal Default Name Fix
🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Railway Preview Environment
|
Summary
fixes #4399
Testing
QA follow-up
check against the reproduction steps of #4399
Checklist
Contributor Resources