Skip to content

[AGE-3773] fix(frontend): remove duplicate 'View details' evaluator menu item#4413

Open
ardaerzin wants to merge 1 commit into
mainfrom
fe-fix/age-3773-evaluator-menu-top-two-actions-have-identical-effect
Open

[AGE-3773] fix(frontend): remove duplicate 'View details' evaluator menu item#4413
ardaerzin wants to merge 1 commit into
mainfrom
fe-fix/age-3773-evaluator-menu-top-two-actions-have-identical-effect

Conversation

@ardaerzin
Copy link
Copy Markdown
Contributor

@ardaerzin ardaerzin commented May 25, 2026

Summary

  • Fixes #4378: the automatic evaluator row menu had two top items — Configure and View details — that both called actions.handleConfigure?.(record) and opened the same drawer.
  • The View details entry was a stub introduced with the new evaluators table and never got its own handler. Removed it so the menu shows a single, distinct action.

Change

web/oss/src/components/Evaluators/Table/assets/evaluatorColumns.tsx — drop the duplicate details menu item from the non-archived, non-human menu. The archived menu's Open details (with its own handleOpen) is untouched.

Test plan

  • Open the Evaluators page (non-archived tab) and open the actions menu on an automatic evaluator row.
  • Confirm the menu shows: Configure → divider → Archive (no View details).
  • Click Configure and verify the evaluator drawer opens as before.
  • Verify the archived tab still shows Open details + Restore.
  • Verify the human evaluators tab still shows Edit + Archive.

Checklist

  • I have included a video or screen recording for UI changes, or marked Demo as N/A
  • Relevant tests pass locally
  • Relevant linting and formatting pass locally
  • I have signed the CLA, or I will sign it when the bot prompts me

Contributor Resources

The 'Configure' and 'View details' items in the automatic evaluator
row menu both called handleConfigure, opening the same drawer. The
'View details' entry was a stub introduced with the new evaluators
table that never got its own handler — remove it.
@linear-code
Copy link
Copy Markdown

linear-code Bot commented May 25, 2026

AGE-3773

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 25, 2026
@vercel
Copy link
Copy Markdown

vercel Bot commented May 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agenta-documentation Ready Ready Preview, Comment May 25, 2026 1:06pm

Request Review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 25, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9b833e74-4008-40fc-bb6d-96c40fd76edc

📥 Commits

Reviewing files that changed from the base of the PR and between 3c9b1db and a044eb3.

📒 Files selected for processing (1)
  • web/oss/src/components/Evaluators/Table/assets/evaluatorColumns.tsx
💤 Files with no reviewable changes (1)
  • web/oss/src/components/Evaluators/Table/assets/evaluatorColumns.tsx

📝 Walkthrough

Summary by CodeRabbit

  • Refactor
    • Updated the action label for non-human evaluators from "View details" to "Configure" in the evaluators table, providing clearer indication of the action's functionality.

Walkthrough

The PR updates the evaluator actions dropdown menu for non-human evaluators in active mode. A "details"/"View details" menu item (with an Eye icon) is replaced with a "configure"/"Configure" item (with a Gear icon). Both options invoke the same actions.handleConfigure handler, clarifying the intended action.

Changes

Evaluator Menu Item Update

Layer / File(s) Summary
Configure Menu Item Replacement
web/oss/src/components/Evaluators/Table/assets/evaluatorColumns.tsx
The non-human evaluator "active" mode dropdown changes from a "details"/"View details" (Eye icon) entry to "configure"/"Configure" (Gear icon), both calling actions.handleConfigure?.(record).

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: removing a duplicate 'View details' evaluator menu item that had the same effect as Configure.
Description check ✅ Passed The description is well-related to the changeset, explaining the duplicate menu item issue, the specific file changed, and providing a comprehensive test plan.
Linked Issues check ✅ Passed The PR fully addresses the linked issue #4378 by removing the duplicate 'View details' menu item that had identical effect to Configure, resolving the problem of ambiguous duplicate UI options.
Out of Scope Changes check ✅ Passed All changes are focused on the specific objective: removing duplicate menu item. No unrelated modifications to archived menu, human evaluators menu, or other components are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fe-fix/age-3773-evaluator-menu-top-two-actions-have-identical-effect

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

Railway Preview Environment

Preview URL https://gateway-production-f7a9.up.railway.app/w
Project agenta-oss-pr-4413
Image tag pr-4413-26ed9d8
Status Deployed
Railway logs Open logs
Workflow logs View workflow run
Updated at 2026-05-25T13:18:55.891Z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Frontend size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Evaluator menu top two actions have identical effect

2 participants