[AGE-3773] fix(frontend): remove duplicate 'View details' evaluator menu item#4413
Conversation
The 'Configure' and 'View details' items in the automatic evaluator row menu both called handleConfigure, opening the same drawer. The 'View details' entry was a stub introduced with the new evaluators table that never got its own handler — remove it.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe PR updates the evaluator actions dropdown menu for non-human evaluators in active mode. A "details"/"View details" menu item (with an Eye icon) is replaced with a "configure"/"Configure" item (with a Gear icon). Both options invoke the same ChangesEvaluator Menu Item Update
🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Railway Preview Environment
|
Summary
actions.handleConfigure?.(record)and opened the same drawer.View detailsentry was a stub introduced with the new evaluators table and never got its own handler. Removed it so the menu shows a single, distinct action.Change
web/oss/src/components/Evaluators/Table/assets/evaluatorColumns.tsx— drop the duplicatedetailsmenu item from the non-archived, non-human menu. The archived menu'sOpen details(with its ownhandleOpen) is untouched.Test plan
Configure→ divider →Archive(noView details).Configureand verify the evaluator drawer opens as before.Open details+Restore.Edit+Archive.Checklist
Contributor Resources