fix(frontend): wire testset connection into workflow drawer playground#4450
fix(frontend): wire testset connection into workflow drawer playground#4450ardaerzin wants to merge 1 commit into
Conversation
The workflow entity create/edit drawer playground had no affordance to connect an existing testset — only local testcases could be edited. ExecutionHeader already exposes a renderTestsetActions slot, but OSS MainLayout never forwarded it, so the drawer (which mounts MainLayout directly with no surrounding header) had no place to surface it. Forward renderTestsetActions through MainLayout → ExecutionItems → ExecutionHeader, and fill the slot in DrawerAppPlayground with the existing TestsetDropdown. Full-page playground is unchanged — its TestsetDropdown still lives in PlaygroundHeader, so there is no duplication.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughSummary by CodeRabbit
WalkthroughPlaygroundMainView imports ChangesTestset Actions Prop Forwarding
🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
The workflow entity create/edit drawer playground had no UI affordance to connect an existing testset — users could only edit local testcases. The full-page playground has
<TestsetDropdown />inPlaygroundHeader, and the evaluator drawer mounts it viaEvaluatorPlaygroundHeader, butDrawerAppPlaygroundrendersPlaygroundMainViewdirectly with no surrounding header, leaving nowhere to place it.ExecutionHeader(the "Generations" header on the right panel) already exposes arenderTestsetActionsrender-slot, but OSSMainLayoutnever forwarded it through toExecutionItems, so the slot was dead code from the OSS side.This change:
renderTestsetActions?: PlaygroundGenerationsProps["renderTestsetActions"]toMainLayoutPropsand forwards it to<ExecutionItems>in the single-view render path.DrawerAppPlayground, passesrenderTestsetActions={() => <TestsetDropdown />}so the dropdown appears next toClear/Run allin the drawer's Generations header.Playground.tsxandDrawerEvaluatorPlaygrounduntouched — both already mountTestsetDropdownvia their own headers, so there is no duplication.Testing
Verified locally
pnpm lint-fixfromweb/— clean (no ESLint warnings or errors across all packages).renderTestsetActionsinExecutionItemsandExecutionHeaderto confirm the slot is already plumbed end-to-end on the package side; the OSS edit only adds the missing forward.Added or updated tests
N/A — the change is a passthrough prop wire plus a one-line slot fill. No new logic to cover, and the package-level
renderTestsetActionsplumbing already exists.QA follow-up
/apps"+ New app" or "+ New evaluator" → workflow type that uses the drawer playground).ClearandRun allin the Generations header.PlaygroundHeader, no duplicate in the Generations header).DrawerEvaluatorPlayground) is unchanged — its testset dropdown still appears inEvaluatorPlaygroundHeaderonce an app is connected.Demo
Screenshot / GIF to be added before merge — drawer Generations header now shows the testset dropdown next to Clear / Run all.
Checklist
Contributor Resources